Showing 59 of 59 total issues
File leaflet.utfgrid.js
has 325 lines of code (exceeds 250 allowed). Consider refactoring. Open
// https://github.com/danzel/Leaflet.utfgrid/blob/18b7043c4a8ac19d4a06658b26e165fb02b8cf1b/src/leaflet.utfgrid.js
// Copyright 2012 David Leaver
// MIT License
L.Util.ajax = function (url, timeout, success, error) {
exports
has 25 functions (exceeds 20 allowed). Consider refactoring. Open
module.exports = class MapConfig {
// Factory like method to create MapConfig objects when you are unsure about being
// able to provide all the MapConfig collaborators or you have to create a MapConfig
// object from a serialized version
static create (rawConfig, datasource) {
File factory.js
has 284 lines of code (exceeds 250 allowed). Consider refactoring. Open
'use strict';
const { rendererFactory: mapnikRendererFactory } = require('@carto/cartonik');
const mapnik = require('@carto/mapnik');
const grainstore = require('grainstore');
Function mapConfigToMMLBuilderConfig
has 68 lines of code (exceeds 25 allowed). Consider refactoring. Open
function mapConfigToMMLBuilderConfig (mapConfig, rendererOptions, mapnikOptions) {
const options = {
ids: [],
sql: [],
originalSql: [],
Function getTileData
has 65 lines of code (exceeds 25 allowed). Consider refactoring. Open
async getTileData (psql, coord, zoom, layerSql, attrs) {
let columnConv = attrs.column;
if (attrs.is_time) {
columnConv = format("date_part('epoch', {column})", attrs);
Function ajax
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
L.Util.ajax = function (url, timeout, success, error) {
if (window.XMLHttpRequest === undefined) {
error(new Error("XMLHttpRequest is not supported"));
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getRenderer
has 59 lines of code (exceeds 25 allowed). Consider refactoring. Open
getRenderer (mapConfig, format, options, callback) {
const isMvt = format === FORMAT_MVT;
if (mapConfig.isVectorOnlyMapConfig() && !isMvt) {
const error = new Error(`Unsupported format: 'cartocss' option is missing for ${format}`);
UtfGrid
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
L.UtfGrid = (L.Layer || L.Class).extend({
includes: L.Mixin.Events,
options: {
subdomains: 'abc',
Function _update
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
_update: function () {
var bounds = this._map.getPixelBounds(),
zoom = this._map.getZoom(),
tileSize = this.options.tileSize;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function constructor
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
constructor (layer, psql, attrs) {
const cartoCssOptions = torque.common.TorqueLayer.optionsFromCartoCSS(layer.options.cartocss);
const rendererOptions = {
bufferSize: cartoCssOptions['buffer-size'] !== undefined ? cartoCssOptions['buffer-size'] : 32
};
Function getFeatureAttributes
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
getFeatureAttributes (mapConfigProvider, params, testMode, callback) {
const timer = new Timer();
mapConfigProvider.getMapConfig((err, mapConfig) => {
if (err) {
Function getRenderer
has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open
getRenderer (mapConfig, format, options, callback) {
const layer = options.layer;
const params = options.params;
const limits = options.limits;
Function getRenderer
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
getRenderer (mapConfig, format, options, callback) {
const layer = options.layer;
const params = options.params;
const limits = options.limits;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Identical blocks of code found in 2 locations. Consider refactoring. Open
for (const [stat, value] of rendererStats) {
if (accumulatedStats.has(stat)) {
accumulatedStats.set(stat, accumulatedStats.get(stat) + value);
} else {
accumulatedStats.set(stat, value);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 71.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
for (const [stat, value] of rendererStats) {
if (accumulatedStats.has(stat)) {
accumulatedStats.set(stat, accumulatedStats.get(stat) + value);
} else {
accumulatedStats.set(stat, value);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 71.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function getLayerColumns
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
function getLayerColumns (psql, layer) {
return new Promise((resolve, reject) => {
if (layer._mvtColumns) {
return resolve();
}
Function validate
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
validate (mapConfigProvider, callback) {
mapConfigProvider.getMapConfig((err, mapConfig, params) => {
if (err) {
return callback(err, false);
}
Function getMetadata
has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open
getMetadata (rendererCache, params, mapConfig, callback) {
const metadataParams = mapConfig.getLayers()
.map((layer, layerId) => {
const getMetadata = this.getLayerMetadataFn(mapConfig, layerId);
return getMetadata ? { getMetadata, mapConfig, layer, layerId, params, rendererCache } : null;
Function attrsFromCartoCSS
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
function attrsFromCartoCSS (cartocss, required) {
const attrsKeys = {
'-torque-frame-count': 'steps',
'-torque-resolution': 'resolution',
'-torque-animation-duration': 'animationDuration',
Function _move
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
_move: function (e) {
var on = this._objectForEvent(e);
if (on.data !== this._mouseOn) {
if (this._mouseOn) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"