Sign upLogin

CartoDB/Windshaft

View on GitHub
Star
lib/models/mapconfig.js

Summary

Maintainability
A
3 hrs
Test Coverage

exports has 25 functions (exceeds 20 allowed). Consider refactoring.
Open

module.exports = class MapConfig {
    // Factory like method to create MapConfig objects when you are unsure about being
    // able to provide all the MapConfig collaborators or you have to create a MapConfig
    // object from a serialized version
    static create (rawConfig, datasource) {
Severity: Minor
Found in lib/models/mapconfig.js - About 2 hrs to fix

    Function getSimplifyExtent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function getSimplifyExtent (layers, vectorExtent) {
    let undef = 0;
    const extents = [...new Set(layers.map(layer => {
        if (layer.options.vector_simplify_extent === undefined) {
            undef++;
    Severity: Minor
    Found in lib/models/mapconfig.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status