Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/controllers/admin/pages_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

File pages_controller.rb has 403 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'active_support/inflector'
require 'carto/api/vizjson3_presenter'

require_relative '../../models/table'
require_relative '../../models/visualization/member'
Severity: Minor
Found in app/controllers/admin/pages_controller.rb - About 5 hrs to fix

    Class PagesController has 38 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Admin::PagesController < Admin::AdminController
  include Carto::HtmlSafe

  include CartoDB
  include VisualizationsControllerHelper
    Severity: Minor
    Found in app/controllers/admin/pages_controller.rb - About 5 hrs to fix

      Method user_feed has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

        def user_feed
    # The template of this endpoint get the user_feed data calling
    # to another endpoint in the front-end part
    render_403 && return if public_profile_disabled?
      Severity: Minor
      Found in app/controllers/admin/pages_controller.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method user_feed has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def user_feed
    # The template of this endpoint get the user_feed data calling
    # to another endpoint in the front-end part
    render_403 && return if public_profile_disabled?
      Severity: Minor
      Found in app/controllers/admin/pages_controller.rb - About 1 hr to fix

        Method render_maps has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def render_maps(vis_query_builder, user=nil)
    set_pagination_vars(
      total_count: vis_query_builder.count,
      per_page:    MAPS_PER_PAGE,
      first_page_url: CartoDB.url(self, 'public_maps_home', user: user),
        Severity: Minor
        Found in app/controllers/admin/pages_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method render_maps has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def render_maps(vis_query_builder, user=nil)
    set_pagination_vars(
      total_count: vis_query_builder.count,
      per_page:    MAPS_PER_PAGE,
      first_page_url: CartoDB.url(self, 'public_maps_home', user: user),
        Severity: Minor
        Found in app/controllers/admin/pages_controller.rb - About 1 hr to fix

          Method sitemap has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def sitemap
    if @viewed_user.nil?
      username = CartoDB.extract_subdomain(request)
      org = get_organization_if_exists(username)
      render_404 and return if org.nil?
          Severity: Minor
          Found in app/controllers/admin/pages_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method set_shared_layout_vars has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def set_shared_layout_vars(model, required, optional = {})
    @twitter_username   = model.twitter_username
    @location           = model.location
    @description        = model.description
    @website            = website_url(model.website)
          Severity: Minor
          Found in app/controllers/admin/pages_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method sitemap has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def sitemap
    if @viewed_user.nil?
      username = CartoDB.extract_subdomain(request)
      org = get_organization_if_exists(username)
      render_404 and return if org.nil?
          Severity: Minor
          Found in app/controllers/admin/pages_controller.rb - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  when Carto::Visualization::TYPE_CANONICAL
        {
          loc: CartoDB.url(self, 'public_table', params: { id: vis.name }, user: vis.user),
          lastfreq: vis.updated_at.strftime("%Y-%m-%dT%H:%M:%S%:z")
        }
            Severity: Minor
            Found in app/controllers/admin/pages_controller.rb and 1 other location - About 15 mins to fix
            app/controllers/admin/pages_controller.rb on lines 82..86

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def datasets
    render_403 && return if public_profile_disabled?

    datasets = CartoDB::ControllerFlows::Public::Datasets.new(self)
    content = CartoDB::ControllerFlows::Public::Content.new(self, request, datasets)
            Severity: Minor
            Found in app/controllers/admin/pages_controller.rb and 1 other location - About 15 mins to fix
            app/controllers/admin/pages_controller.rb on lines 105..110

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  when Carto::Visualization::TYPE_DERIVED
        {
          loc: CartoDB.url(self, 'public_visualizations_public_map', params: { id: vis.id }, user: vis.user),
          lastfreq: vis.updated_at.strftime("%Y-%m-%dT%H:%M:%S%:z")
        }
            Severity: Minor
            Found in app/controllers/admin/pages_controller.rb and 1 other location - About 15 mins to fix
            app/controllers/admin/pages_controller.rb on lines 87..91

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def maps
    render_403 && return if public_profile_disabled?

    maps = CartoDB::ControllerFlows::Public::Maps.new(self)
    content = CartoDB::ControllerFlows::Public::Content.new(self, request, maps)
            Severity: Minor
            Found in app/controllers/admin/pages_controller.rb and 1 other location - About 15 mins to fix
            app/controllers/admin/pages_controller.rb on lines 97..102

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 25.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status