Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/controllers/api/json/synchronizations_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method create has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    return head(401) unless current_user.sync_tables_enabled || @external_source

    @stats_aggregator.timing('synchronizations.create') do
Severity: Minor
Found in app/controllers/api/json/synchronizations_controller.rb - About 1 hr to fix

    Method sync has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def sync(from_sync_now=false)
    @stats_aggregator.timing('synchronizations.sync') do

      begin
        enqueued = false
    Severity: Minor
    Found in app/controllers/api/json/synchronizations_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setup_data_import_options has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def setup_data_import_options(member_attributes, member_id)
    if from_sync_file_provider?
      service_name = params[:service_name]
      service_item_id = params[:service_item_id]
    else
    Severity: Minor
    Found in app/controllers/api/json/synchronizations_controller.rb - About 1 hr to fix

      Method setup_data_import_options has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def setup_data_import_options(member_attributes, member_id)
    if from_sync_file_provider?
      service_name = params[:service_name]
      service_item_id = params[:service_item_id]
    else
      Severity: Minor
      Found in app/controllers/api/json/synchronizations_controller.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def create
    return head(401) unless current_user.sync_tables_enabled || @external_source

    @stats_aggregator.timing('synchronizations.create') do
      Severity: Minor
      Found in app/controllers/api/json/synchronizations_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status