Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/controllers/carto/api/layers_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class LayersController has 29 methods (exceeds 20 allowed). Consider refactoring.
Open

    class LayersController < ::Api::ApplicationController
      ssl_required :show, :layers_by_map, :custom_layers_by_user, :map_index, :user_index, :map_show, :user_show,
                   :map_create, :user_create, :map_update, :user_update, :map_destroy, :user_destroy

      before_filter :ensure_current_user, only: [:user_index, :user_show, :user_create, :user_update, :user_destroy]
Severity: Minor
Found in app/controllers/carto/api/layers_controller.rb - About 3 hrs to fix

    Method update has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

          def update
        layers = @layers.map do |layer|
          layer_params = params[:layers].present? ? params[:layers].find { |p| p['id'] == layer.id } : params

          # don't allow to override table_name and user_name
    Severity: Minor
    Found in app/controllers/carto/api/layers_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_for_map has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def validate_for_map(layer)
        unless @map.can_add_layer?(current_user, layer)
          raise UnprocesableEntityError.new('Cannot add more layers to this visualization')
        end
        unless @map.admits_layer?(layer)
    Severity: Minor
    Found in app/controllers/carto/api/layers_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method move_layer_node_styles has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def move_layer_node_styles(from_layer, from_letter, to_layer, to_letter, to_source)
    Severity: Minor
    Found in app/controllers/carto/api/layers_controller.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status