Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/controllers/carto/api/visualization_searcher.rb

Summary

Maintainability
C
1 day
Test Coverage

Method query_builder_with_filter_from_hash has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

      def query_builder_with_filter_from_hash(params)
        types = get_types_parameters

        validate_parameters(types, params)
Severity: Minor
Found in app/controllers/carto/api/visualization_searcher.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method query_builder_with_filter_from_hash has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def query_builder_with_filter_from_hash(params)
        types = get_types_parameters

        validate_parameters(types, params)
Severity: Major
Found in app/controllers/carto/api/visualization_searcher.rb - About 2 hrs to fix

    Method get_types_parameters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def get_types_parameters
        # INFO: this fits types and type into types, so only types is used for search.
        # types defaults to type if empty.
        # types defaults to derived if type is also empty.
        types = params.fetch(:types, "").split(',')
    Severity: Minor
    Found in app/controllers/carto/api/visualization_searcher.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method compose_shared has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def compose_shared(shared, only_shared, exclude_shared)
        valid_shared = shared if [FILTER_SHARED_ONLY, FILTER_SHARED_NO, FILTER_SHARED_YES].include?(shared)
        return valid_shared if valid_shared

        if only_shared
    Severity: Minor
    Found in app/controllers/carto/api/visualization_searcher.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status