Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/controllers/carto/api/visualizations_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

File visualizations_controller.rb has 417 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative 'visualization_presenter'
require_dependency 'carto/api/vizjson_presenter'
require_relative '../../../models/visualization/stats'
require_relative 'paged_searcher'
require_relative '../controller_helper'
Severity: Minor
Found in app/controllers/carto/api/visualizations_controller.rb - About 6 hrs to fix

    Class VisualizationsController has 34 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class VisualizationsController < ::Api::ApplicationController
      include VisualizationSearcher
      include PagedSearcher
      include Carto::UUIDHelper
      include VisualizationsControllerHelper
    Severity: Minor
    Found in app/controllers/carto/api/visualizations_controller.rb - About 4 hrs to fix

      Method update has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

            def update
        vis = @visualization

        return head(403) unless payload[:id] == vis.id
        return head(403) unless vis.has_permission?(current_user, Carto::Permission::ACCESS_READWRITE)
      Severity: Minor
      Found in app/controllers/carto/api/visualizations_controller.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

            def create
        vis_data = payload

        vis_data.delete(:permission)
        vis_data.delete(:permission_id)
      Severity: Minor
      Found in app/controllers/carto/api/visualizations_controller.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def create
        vis_data = payload

        vis_data.delete(:permission)
        vis_data.delete(:permission_id)
      Severity: Minor
      Found in app/controllers/carto/api/visualizations_controller.rb - About 1 hr to fix

        Method destroy has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

              def destroy
        return head(403) unless @visualization.has_permission?(current_viewer, Carto::Permission::ACCESS_READWRITE)

        current_viewer_id = current_viewer.id
        properties = { user_id: current_viewer_id, visualization_id: @visualization.id }
        Severity: Minor
        Found in app/controllers/carto/api/visualizations_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method update has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def update
        vis = @visualization

        return head(403) unless payload[:id] == vis.id
        return head(403) unless vis.has_permission?(current_user, Carto::Permission::ACCESS_READWRITE)
        Severity: Minor
        Found in app/controllers/carto/api/visualizations_controller.rb - About 1 hr to fix

          Method index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def index
        offdatabase_orders = Carto::VisualizationQueryOrderer::SUPPORTED_OFFDATABASE_ORDERS.map(&:to_sym)
        valid_order_combinations = VALID_ORDER_PARAMS - offdatabase_orders
        opts = { valid_order_combinations: valid_order_combinations }
        page, per_page, order, order_direction = page_per_page_order_params(VALID_ORDER_PARAMS, opts)
          Severity: Minor
          Found in app/controllers/carto/api/visualizations_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def id_and_schema_from_params
        if params.fetch('id', nil) =~ /\./
          @id, @schema = params.fetch('id').split('.').reverse
        else
          @id, @schema = [params.fetch('id', nil), nil]
          Severity: Minor
          Found in app/controllers/carto/api/visualizations_controller.rb and 1 other location - About 25 mins to fix
          app/controllers/admin/visualizations_controller.rb on lines 532..537

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status