Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/mailers/import_mailer.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method data_import_finished has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def data_import_finished(user, imported_tables, total_tables, first_imported_table, first_table, errors, filenames)
Severity: Major
Found in app/mailers/import_mailer.rb - About 50 mins to fix

    Method data_import_finished has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def data_import_finished(user, imported_tables, total_tables, first_imported_table, first_table, errors, filenames)
    @errors = errors
    @imported_tables = imported_tables
    @total_tables = total_tables
    @subject = set_subject
    Severity: Minor
    Found in app/mailers/import_mailer.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method set_subject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def set_subject
    if @total_tables == 1
      if @errors.nil?
        subject = "Your dataset import just finished"
      else
    Severity: Minor
    Found in app/mailers/import_mailer.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status