Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/models/asset.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class Asset has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class Asset < Sequel::Model
  include Carto::Configuration

  many_to_one :user
Severity: Minor
Found in app/models/asset.rb - About 2 hrs to fix

    Method validate_file has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

      def validate_file
    extension = asset_file_extension
    unless VALID_EXTENSIONS.include?(extension)
      errors.add(:file, "has invalid format")
      return
    Severity: Minor
    Found in app/models/asset.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method store has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def store
    return unless @file
    filename = (@file.respond_to?(:original_filename) ? @file.original_filename : File.basename(@file))
    filename = "#{Time.now.strftime("%Y%m%d%H%M%S")}#{filename}"
    Severity: Minor
    Found in app/models/asset.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status