Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/models/carto/notification.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method send_to_organization_members has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def send_to_organization_members
      return unless organization
      # This avoids resending an already sent notification. Example: importing notifications
      return unless received_notifications.empty?
      users = if recipients == 'builders'
Severity: Minor
Found in app/models/carto/notification.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method valid_markdown has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def valid_markdown
      return unless body.present?
      text = Redcarpet::Markdown.new(NotificationsMarkdownRenderer).render(body).strip
      errors.add(:body, "cannot be longer than #{MAX_BODY_LENGTH} characters") if text.length > MAX_BODY_LENGTH
    rescue RuntimeError => e
Severity: Minor
Found in app/models/carto/notification.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status