Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/models/geocoding.rb

Summary

Maintainability
D
1 day
Test Coverage

Class Geocoding has 33 methods (exceeds 20 allowed). Consider refactoring.
Open

class Geocoding < Sequel::Model
  include Carto::Configuration

  ALLOWED_KINDS   = %w(admin0 admin1 namedplace postalcode high-resolution ipaddress)
Severity: Minor
Found in app/models/geocoding.rb - About 4 hrs to fix

    File geocoding.rb has 313 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'socket'
require_relative '../../services/table-geocoder/lib/table_geocoder_factory'
require_relative '../../services/table-geocoder/lib/exceptions'
require_relative '../../services/table-geocoder/lib/mail_geocoder'
require_relative '../../services/geocoder/lib/geocoder_config'
    Severity: Minor
    Found in app/models/geocoding.rb - About 3 hrs to fix

      Method metrics_payload has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def metrics_payload(exception = nil)
    payload = {
      created_at:       created_at,
      distinct_id:      user.username,
      username:         user.username,
      Severity: Minor
      Found in app/models/geocoding.rb - About 1 hr to fix

        Method run! has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def run!
    @started_at = Time.now
    log.append_and_store "Running geocoding job on server #{Socket.gethostname} with PID: #{Process.pid}"
    if self.force_all_rows == true
      table_geocoder.reset_cartodb_georef_status
        Severity: Minor
        Found in app/models/geocoding.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method calculate_used_credits has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def calculate_used_credits
    return 0 unless kind == 'high-resolution' && geocoder_type == 'heremaps'
    total_rows       = processed_rows.to_i + cache_hits.to_i
    geocoding_quota  = user.organization.present? ? user.organization.geocoding_quota.to_i : user.geocoding_quota
    used_geocoding_calls = user.organization_user? ? user.organization.get_geocoding_calls : user.get_geocoding_calls
        Severity: Minor
        Found in app/models/geocoding.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run_geocoding! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def run_geocoding!(processable_rows, rows_geocoded_before = 0)
    log.append_and_store "run_geocoding!()"
    self.update state: 'started', processable_rows: processable_rows
    @started_at ||= Time.now
        Severity: Minor
        Found in app/models/geocoding.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method send_report_mail has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def send_report_mail(state, table_name, error_code=nil, processable_rows, number_geocoded_rows)
        Severity: Minor
        Found in app/models/geocoding.rb - About 35 mins to fix

          Method cancel has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def cancel
    log.append_and_store "Cancelling job because of user request"
    table_geocoder.cancel
  rescue StandardError => e
    log.append_and_store "Error trying to cancel a job because of user request: #{e.inspect}"
          Severity: Minor
          Found in app/models/geocoding.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method metrics_payload has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def metrics_payload(exception = nil)
    payload = {
      created_at:       created_at,
      distinct_id:      user.username,
      username:         user.username,
          Severity: Minor
          Found in app/models/geocoding.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            def self.processable_rows(table_service, force_all_rows=false)
    dataset = table_service.owner.in_database.select.from(table_service.sequel_qualified_table_name)
    if !force_all_rows && dataset.columns.include?(:cartodb_georef_status)
      dataset = dataset.exclude(cartodb_georef_status: true)
    end
          Severity: Minor
          Found in app/models/geocoding.rb and 1 other location - About 25 mins to fix
          app/models/carto/geocoding.rb on lines 14..19

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 29.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status