Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
app/models/synchronization/adapter.rb

Summary

Maintainability
F
3 days
Test Coverage

File adapter.rb has 338 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'carto/importer/table_setup'

module CartoDB
  module Synchronization
    class Adapter
Severity: Minor
Found in app/models/synchronization/adapter.rb - About 4 hrs to fix

    Method swap_tables has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

          def swap_tables(table_name, temporary_name, result)
        database.transaction do
          rename(table_name, temporary_name) if exists?(table_name)
          drop(temporary_name) if exists?(temporary_name)
          rename(result.table_name, table_name)
    Severity: Minor
    Found in app/models/synchronization/adapter.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Adapter has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Adapter

      include ::LoggerHelper

      STATEMENT_TIMEOUT = (1.hour * 1000).freeze
    Severity: Minor
    Found in app/models/synchronization/adapter.rb - About 3 hrs to fix

      Method import_cleanup has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

            def import_cleanup(schema_name, table_name)
        qualified_table_name = "\"#{schema_name}\".#{table_name}"

        user.db_service.in_database_direct_connection(statement_timeout: STATEMENT_TIMEOUT) do |user_database|
      Severity: Minor
      Found in app/models/synchronization/adapter.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method overwrite_sync has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

            def overwrite_sync(schema, table_name, result, geo_type)
        return false unless runner.remote_data_updated?

        # NOTE the import table is already moved to the user schema;
        # this was done (#7543) because the cartodbfication performs
      Severity: Minor
      Found in app/models/synchronization/adapter.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import_cleanup has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def import_cleanup(schema_name, table_name)
        qualified_table_name = "\"#{schema_name}\".#{table_name}"

        user.db_service.in_database_direct_connection(statement_timeout: STATEMENT_TIMEOUT) do |user_database|
      Severity: Minor
      Found in app/models/synchronization/adapter.rb - About 1 hr to fix

        Method fix_the_geom_type! has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def fix_the_geom_type!(schema_name, table_name)
        qualified_table_name = "\"#{schema_name}\".#{table_name}"

        type = nil
        the_geom_data = user.in_database[%Q{
        Severity: Minor
        Found in app/models/synchronization/adapter.rb - About 1 hr to fix

          Method swap_tables has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def swap_tables(table_name, temporary_name, result)
        database.transaction do
          rename(table_name, temporary_name) if exists?(table_name)
          drop(temporary_name) if exists?(temporary_name)
          rename(result.table_name, table_name)
          Severity: Minor
          Found in app/models/synchronization/adapter.rb - About 1 hr to fix

            Method run has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def run(&tracker)
        runner.run(&tracker)
        result = runner.results.select(&:success?).first

        if runner.remote_data_updated?
            Severity: Minor
            Found in app/models/synchronization/adapter.rb - About 1 hr to fix

              Method overwrite_sync has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def overwrite_sync(schema, table_name, result, geo_type)
        return false unless runner.remote_data_updated?

        # NOTE the import table is already moved to the user schema;
        # this was done (#7543) because the cartodbfication performs
              Severity: Minor
              Found in app/models/synchronization/adapter.rb - About 1 hr to fix

                Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                      def run(&tracker)
        runner.run(&tracker)
        result = runner.results.select(&:success?).first

        if runner.remote_data_updated?
                Severity: Minor
                Found in app/models/synchronization/adapter.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method overwrite_replace has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                      def overwrite_replace(schema, table_name, result)
        return false unless runner.remote_data_updated?

        table_statements = @table_setup.generate_table_statements(schema, table_name)
                Severity: Minor
                Found in app/models/synchronization/adapter.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method initialize has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def initialize(table_name, runner, database, user, overviews_creator, synchronization_id, logger = nil)
                Severity: Major
                Found in app/models/synchronization/adapter.rb - About 50 mins to fix

                  Method fix_the_geom_type! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def fix_the_geom_type!(schema_name, table_name)
        qualified_table_name = "\"#{schema_name}\".#{table_name}"

        type = nil
        the_geom_data = user.in_database[%Q{
                  Severity: Minor
                  Found in app/models/synchronization/adapter.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        rescue StandardError => exception
        @error_code = OVERWRITE_ERROR
        puts "Sync overwrite ERROR: #{exception.message}: #{exception.backtrace.join}"

        # Gets all attributes in the result except for 'log_trace', as it is too long for Rollbar
                  Severity: Major
                  Found in app/models/synchronization/adapter.rb and 1 other location - About 1 hr to fix
                  app/models/synchronization/adapter.rb on lines 148..158

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 53.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        rescue StandardError => exception
        @error_code = OVERWRITE_ERROR
        puts "Sync overwrite ERROR: #{exception.message}: #{exception.backtrace.join}"

        # Gets all attributes in the result except for 'log_trace', as it is too long for Rollbar
                  Severity: Major
                  Found in app/models/synchronization/adapter.rb and 1 other location - About 1 hr to fix
                  app/models/synchronization/adapter.rb on lines 126..136

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 53.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status