app/services/carto/do_licensing_service.rb
Consider simplifying this complex logical expression. Open
Open
if dataset[:available_in].include?(storage)
# Remove a previous dataset if exists
redis_value = redis_value.reject { |d| d['dataset_id'] == dataset[:dataset_id] }
# Initial sync status
Method insert_redis_value
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
def insert_redis_value(dataset, storage)
redis_value = JSON.parse($users_metadata.hget(@redis_key, storage) || '[]')
if dataset[:available_in].include?(storage)
# Remove a previous dataset if exists
redis_value = redis_value.reject { |d| d['dataset_id'] == dataset[:dataset_id] }
Method insert_redis_value
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def insert_redis_value(dataset, storage)
redis_value = JSON.parse($users_metadata.hget(@redis_key, storage) || '[]')
if dataset[:available_in].include?(storage)
# Remove a previous dataset if exists
redis_value = redis_value.reject { |d| d['dataset_id'] == dataset[:dataset_id] }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"