CartoDB/cartodb20

Identical blocks of code found in 4 locations. Consider refactoring.

Open

      def run
        n_layers = layers_in(source_file).length
        return self if n_layers <= 1

        if n_layers > MAX_LAYERS

• Read up
  Read up

Identical blocks of code found in 4 locations. Consider refactoring.

Open

      def run
        n_layers = layers_in(source_file).length
        return self if n_layers <= 1
        if n_layers > MAX_LAYERS
          raise CartoDB::Importer2::TooManyLayersError.new(

• Read up
  Read up

Identical blocks of code found in 4 locations. Consider refactoring.

Open

      def run
        n_layers = layers_in(source_file).length
        return self if n_layers <= 1
        raise CartoDB::Importer2::TooManyLayersError.new("File has too many layers (#{n_layers}). Maximum number of layers: #{MAX_LAYERS}") if n_layers > MAX_LAYERS
        @source_files = source_files_for(source_file, layers_in(source_file))

• Read up
  Read up

Identical blocks of code found in 4 locations. Consider refactoring.

Open

      def run
        n_layers = layers_in(source_file).length
        return self if n_layers <= 1
        raise CartoDB::Importer2::TooManyLayersError.new(
          "File has too many layers (#{n_layers}). Maximum number of layers: #{MAX_LAYERS}"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def export_oauth_token(oauth_token)
      {
        token: oauth_token.token,
        secret: oauth_token.secret,
        callback_url: oauth_token.callback_url,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def parse_fill(fill)
      width = fill[:size][:fixed]
      color = fill[:color][:fixed]
      opacity = fill[:color][:opacity]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def parse_stroke(stroke)
      width = stroke[:size][:fixed]
      color = stroke[:color][:fixed]
      opacity = stroke[:color][:opacity]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def export_api_key(api_key)
      {
        id: api_key.id,
        created_at: api_key.created_at,
        db_password: api_key.db_password,

• Read up
  Read up

Avoid too many return statements within this function.

Open

        return "variable";

Avoid too many return statements within this function.

Open

        if(state.stack[state.stack.length-1] != undefined)return ret(null, ch);

Avoid too many return statements within this function.

Open

      return ret("number", "unit");

Avoid too many return statements within this function.

Open

        return ret("number", "unit");

Avoid too many return statements within this function.

Open

          return state.tagStart + indentUnit * multilineTagIndentFactor;

Avoid too many return statements within this function.

Open

        if(type == "r")return ret("string", "string");

Avoid too many return statements within this function.

Open

      return "atom";

Avoid too many return statements within this function.

Open

      return "word";

Avoid too many return statements within this function.

Open

      if(stream.peek() == ")")return ret("number", "unit");//rgba(0,0,0,.25);

Avoid too many return statements within this function.

Open

          return ret("atom", "tag");

Avoid too many return statements within this function.

Open

          return null;

Avoid too many return statements within this function.

Open

      return ok ? "atom" : "error";