Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/carto/oauth_provider/grant_strategies.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method authorize! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def self.authorize!(oauth_app, params)
          authorization_code = OauthAuthorizationCode.find_by_code!(params[:code])
          raise OauthProvider::Errors::InvalidGrant.new unless authorization_code.oauth_app == oauth_app

          redirect_uri = params[:redirect_uri]
Severity: Minor
Found in lib/carto/oauth_provider/grant_strategies.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method authorize! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def self.authorize!(oauth_app, params)
          refresh_token = OauthRefreshToken.find_by_token!(params[:refresh_token])
          raise OauthProvider::Errors::InvalidGrant.new unless refresh_token.oauth_app == oauth_app

          if params[:scope]
Severity: Minor
Found in lib/carto/oauth_provider/grant_strategies.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status