Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/cartodb/central.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class Central has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Central

    include ::MessageBrokerHelper

    def self.message_broker_sync_enabled?
Severity: Minor
Found in lib/cartodb/central.rb - About 4 hrs to fix

    Method send_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def send_request(path, body, method, expected_codes, timeout = nil)
    Severity: Minor
    Found in lib/cartodb/central.rb - About 35 mins to fix

      Method send_request has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def send_request(path, body, method, expected_codes, timeout = nil)
      request = build_request(path, body, method, timeout)
      response = request.run
      if expected_codes.include?(response.code)
        return response.body && response.body.length >= 2 ? JSON.parse(response.body) : {}
      Severity: Minor
      Found in lib/cartodb/central.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status