Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/user_account_creator.rb

Summary

Maintainability
C
1 day
Test Coverage

Class UserAccountCreator has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

  class UserAccountCreator
    include DummyPasswordGenerator

    PARAM_USERNAME = :username
    PARAM_EMAIL = :email
Severity: Minor
Found in lib/user_account_creator.rb - About 3 hrs to fix

    Method valid? has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def valid?
      build

      if @organization
        if @organization.owner.nil?
    Severity: Minor
    Found in lib/user_account_creator.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        def build
      return if @built

      if generate_dummy_password?
        dummy_password = generate_dummy_password
    Severity: Minor
    Found in lib/user_account_creator.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def build
      return if @built

      if generate_dummy_password?
        dummy_password = generate_dummy_password
    Severity: Minor
    Found in lib/user_account_creator.rb - About 1 hr to fix

      Method valid? has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def valid?
      build

      if @organization
        if @organization.owner.nil?
      Severity: Minor
      Found in lib/user_account_creator.rb - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status