Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
services/datasources/lib/datasources/url/box.rb

Summary

Maintainability
D
2 days
Test Coverage

File box.rb has 397 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require_relative '../../../../../lib/carto/http/client'

module CartoDB
  module Datasources
    module Url
Severity: Minor
Found in services/datasources/lib/datasources/url/box.rb - About 5 hrs to fix

    Method search has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

              def search(query, options = {})
            scope = options[:scope]
            file_extensions = options[:file_extensions]
            created_at_range = options[:created_at_range]
            updated_at_range = options[:updated_at_range]
    Severity: Minor
    Found in services/datasources/lib/datasources/url/box.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class Box has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

          class Box < BaseOAuth

        # Required for all providers
        DATASOURCE_NAME = 'box'
    Severity: Minor
    Found in services/datasources/lib/datasources/url/box.rb - About 2 hrs to fix

      Method search has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                def search(query, options = {})
            scope = options[:scope]
            file_extensions = options[:file_extensions]
            created_at_range = options[:created_at_range]
            updated_at_range = options[:updated_at_range]
      Severity: Minor
      Found in services/datasources/lib/datasources/url/box.rb - About 1 hr to fix

        Method download_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                  def download_file(file, options = {})
            version = options[:version]
            follow_redirect = options.fetch(:follow_redirect, true)

            file_id = ensure_id(file)
        Severity: Minor
        Found in services/datasources/lib/datasources/url/box.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get_tokens has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

                def self.get_tokens(code, options = {})
          grant_type = options[:grant_type]
          assertion = options[:assertion]
          scope = options[:scope]
          username = options[:username]
        Severity: Minor
        Found in services/datasources/lib/datasources/url/box.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method token_valid? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def token_valid?
          raise 'invalid_token' unless token

          # Any call would do, we just want to see if communicates or refuses the token
          result = client.search('test search')
        Severity: Minor
        Found in services/datasources/lib/datasources/url/box.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method get has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                  def get(uri, options = {})
            query = options[:query]
            success_codes = options.fetch(:success_codes, [200])
            process_response = options.fetch(:process_response, true)
            if_match = options[:if_match]
        Severity: Minor
        Found in services/datasources/lib/datasources/url/box.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  FOLDER_AND_FILE_FIELDS = [:type, :id, :sequence_id, :etag, :name, :created_at, :modified_at, :description,
                                    :size, :path_collection, :created_by, :modified_by, :trashed_at, :purged_at,
                                    :content_created_at, :content_modified_at, :owned_by, :shared_link,
                                    :folder_upload_email,
                                    :parent, :item_status, :item_collection, :sync_state, :has_collaborations,
        Severity: Minor
        Found in services/datasources/lib/datasources/url/box.rb and 1 other location - About 35 mins to fix
        app/models/concerns/cartodb_central_synchronizable.rb on lines 89..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 36.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                def validate_callback(params)
          if params[:error].present?
            raise AuthError.new("validate_callback: #{params[:error]}", DATASOURCE_NAME)
          end
        Severity: Minor
        Found in services/datasources/lib/datasources/url/box.rb and 2 other locations - About 25 mins to fix
        services/datasources/lib/datasources/url/bigquery.rb on lines 82..90
        services/datasources/lib/datasources/url/gdrive.rb on lines 112..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 29.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status