Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
services/datasources/lib/datasources/url/gdrive.rb

Summary

Maintainability
C
1 day
Test Coverage

Method get_resource has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

        def get_resource(id)
          @drive.get_file(id) do |file, err|
            if err
              error_msg = "(#{err.status_code}) retrieving file #{id}: #{err}"
              raise DataDownloadError.new(error_msg, DATASOURCE_NAME)
Severity: Minor
Found in services/datasources/lib/datasources/url/gdrive.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_resources_list has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

        def get_resources_list(filter=[])
          all_results = []
          self.filter = filter

          @drive.batch do |d|
Severity: Minor
Found in services/datasources/lib/datasources/url/gdrive.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get_resources_list has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        def get_resources_list(filter=[])
          all_results = []
          self.filter = filter

          @drive.batch do |d|
Severity: Minor
Found in services/datasources/lib/datasources/url/gdrive.rb - About 1 hr to fix

    Method get_resource_metadata has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

            def get_resource_metadata(id)
          @drive.get_file(id) do |file, err|
            if err
              case err.status_code
              when 404
    Severity: Minor
    Found in services/datasources/lib/datasources/url/gdrive.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_auth_code has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def validate_auth_code(auth_code, use_callback_flow = true)
          unless use_callback_flow
            @client.redirect_uri = REDIRECT_URI
          end
          @client.code = auth_code
    Severity: Minor
    Found in services/datasources/lib/datasources/url/gdrive.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            def token=(token)
          @refresh_token = token
          @client.update_token!(refresh_token: @refresh_token)
          @client.fetch_access_token!
        rescue Google::Apis::AuthorizationError, Signet::AuthorizationError => ex
    Severity: Major
    Found in services/datasources/lib/datasources/url/gdrive.rb and 1 other location - About 1 hr to fix
    services/datasources/lib/datasources/url/bigquery.rb on lines 133..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            def validate_callback(params)
          if params[:error].present?
            raise AuthError.new("validate_callback: #{params[:error]}", DATASOURCE_NAME)
          end
    Severity: Minor
    Found in services/datasources/lib/datasources/url/gdrive.rb and 2 other locations - About 25 mins to fix
    services/datasources/lib/datasources/url/bigquery.rb on lines 82..90
    services/datasources/lib/datasources/url/box.rb on lines 356..364

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 29.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            def filter=(filter_data=[])
          @formats = []
          FORMATS_TO_MIME_TYPES.each do |id, mime_types|
            if filter_data.empty? || filter_data.include?(id)
              mime_types.each do |mime_type|
    Severity: Minor
    Found in services/datasources/lib/datasources/url/gdrive.rb and 1 other location - About 15 mins to fix
    services/datasources/lib/datasources/url/dropbox.rb on lines 181..188

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status