Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
services/geocoder/lib/hires_batch_geocoder.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class HiresBatchGeocoder has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

  class HiresBatchGeocoder < HiresGeocoderInterface

    DEFAULT_TIMEOUT = 5.hours
    POLLING_SLEEP_TIME = 5.seconds
    LOGGING_TIME = 5.minutes
Severity: Minor
Found in services/geocoder/lib/hires_batch_geocoder.rb - About 2 hrs to fix

    File hires_batch_geocoder.rb has 258 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'open3'
require 'nokogiri'
require 'csv'
require 'active_support/core_ext/numeric'
require_relative '../../../lib/carto/http/client'
    Severity: Minor
    Found in services/geocoder/lib/hires_batch_geocoder.rb - About 2 hrs to fix

      Method result has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          def result
      return @result unless @result.nil?

      raise 'No request_id provided' unless @geocoding_model.remote_id
      results_filename = File.join(dir, "#{@geocoding_model.remote_id}.zip")
      Severity: Minor
      Found in services/geocoder/lib/hires_batch_geocoder.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def run
      init_rows_count
      @log.append_and_store "Started batched Here geocoding job"
      @started_at = Time.now
      change_status('running')
      Severity: Minor
      Found in services/geocoder/lib/hires_batch_geocoder.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def run
      init_rows_count
      @log.append_and_store "Started batched Here geocoding job"
      @started_at = Time.now
      change_status('running')
        Severity: Minor
        Found in services/geocoder/lib/hires_batch_geocoder.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status