Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
services/importer/lib/importer/ogr2ogr.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Ogr2ogr has 39 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Ogr2ogr
      ENCODING  = 'UTF-8'
      SCHEMA    = 'cdb_importer'

      PG_COPY_OPTION        = { 'PG_USE_COPY' => 'YES' }.freeze
Severity: Minor
Found in services/importer/lib/importer/ogr2ogr.rb - About 5 hrs to fix

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def initialize(table_name, filepath, pg_options, layer=nil, options={})
    Severity: Minor
    Found in services/importer/lib/importer/ogr2ogr.rb - About 35 mins to fix

      Method file_too_big? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def file_too_big?
        (exit_code == 256 && command_output =~ /calloc failed/i) ||
          (exit_code == 256 && command_output =~ /out of memory/i) ||
          (exit_code == 134) ||
          (exit_code == 139) ||
      Severity: Minor
      Found in services/importer/lib/importer/ogr2ogr.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status