Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
services/platform-limits/lib/abstract_limit.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Class AbstractLimit has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

    class AbstractLimit

      TYPE_USER = 'u'
      TYPE_IP = 'i'
Severity: Minor
Found in services/platform-limits/lib/abstract_limit.rb - About 2 hrs to fix

    Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def initialize(options={})
        @user = options.fetch(:user, nil)
        @ip = options.fetch(:ip, nil)
        raise ArgumentError.new('options must be a Hash') unless options.is_a?(Hash)
        raise ArgumentError.new('Must supply at least a user or an IP address') if @user.nil? && @ip.nil?
    Severity: Minor
    Found in services/platform-limits/lib/abstract_limit.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status