Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
services/synchronizer/lib/synchronizer/collection.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method fetch_and_enqueue has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def fetch_and_enqueue(force_all_syncs=false)
        begin
          if force_all_syncs
            query = db.fetch(%Q(
              SELECT r.name, r.id FROM #{relation} r, users u WHERE
Severity: Minor
Found in services/synchronizer/lib/synchronizer/collection.rb - About 1 hr to fix

    Method fetch_and_enqueue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def fetch_and_enqueue(force_all_syncs=false)
        begin
          if force_all_syncs
            query = db.fetch(%Q(
              SELECT r.name, r.id FROM #{relation} r, users u WHERE
    Severity: Minor
    Found in services/synchronizer/lib/synchronizer/collection.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method enqueue_rate_limited has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def enqueue_rate_limited(query)

        query.each { |record|
          user = Carto::User.where(id: record[:user_id]).first
          next if user.nil?
    Severity: Minor
    Found in services/synchronizer/lib/synchronizer/collection.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status