Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
services/table-geocoder/lib/table_geocoder_factory.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method get has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.get(user, geocoding_model, cartodb_geocoder_config, table_service, params = {})
      # Reset old connections to make sure changes apply.
      # NOTE: This assumes it's being called from a Resque job
      user.db_service.reset_pooled_connections
      log = params.fetch(:log)
Severity: Minor
Found in services/table-geocoder/lib/table_geocoder_factory.rb - About 1 hr to fix

    Method get has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.get(user, geocoding_model, cartodb_geocoder_config, table_service, params = {})
      # Reset old connections to make sure changes apply.
      # NOTE: This assumes it's being called from a Resque job
      user.db_service.reset_pooled_connections
      log = params.fetch(:log)
    Severity: Minor
    Found in services/table-geocoder/lib/table_geocoder_factory.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def self.get(user, geocoding_model, cartodb_geocoder_config, table_service, params = {})
    Severity: Minor
    Found in services/table-geocoder/lib/table_geocoder_factory.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status