CastagnaIT/plugin.video.netflix

View on GitHub
resources/lib/common/videoid.py

Summary

Maintainability
A
3 hrs
Test Coverage

VideoId has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

class VideoId:
    """Universal representation of a video id. Video IDs can be of multiple types:
    - supplemental: a single identifier only for supplementalid, all other values must be None
    - movie: a single identifier only for movieid, all other values must be None
    - show: a single identifier only for tvshowid, all other values must be None
Severity: Minor
Found in resources/lib/common/videoid.py - About 3 hrs to fix

    Cyclomatic complexity is too high in method to_string. (6)
    Open

        def to_string(self):
            """Generate a valid pathitems as string ('show'/tvshowid/...) from this instance"""
            if self.videoid:
                return self.videoid
            if self.movieid:
    Severity: Minor
    Found in resources/lib/common/videoid.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Cyclomatic complexity is too high in method to_path. (6)
    Open

        def to_path(self):
            """Generate a valid pathitems list (['show', tvshowid, ...]) from
            this instance"""
            if self.videoid:
                return [self.videoid]
    Severity: Minor
    Found in resources/lib/common/videoid.py by radon

    Cyclomatic Complexity

    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

    Construct Effect on CC Reasoning
    if +1 An if statement is a single decision.
    elif +1 The elif statement adds another decision.
    else +0 The else statement does not cause a new decision. The decision is at the if.
    for +1 There is a decision at the start of the loop.
    while +1 There is a decision at the while statement.
    except +1 Each except branch adds a new conditional path of execution.
    finally +0 The finally block is unconditionally executed.
    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
    assert +1 The assert statement internally roughly equals a conditional statement.
    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

    Source: http://radon.readthedocs.org/en/latest/intro.html

    Function _path_to_videoid has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _path_to_videoid(kwargs, pathitems_arg, path_offset,
    Severity: Minor
    Found in resources/lib/common/videoid.py - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status