Sign upLogin

CastagnaIT/plugin.video.netflix

View on GitHub
Star
resources/lib/services/nfsession/directorybuilder/dir_builder.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function get_video_list_sorted_sp has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def get_video_list_sorted_sp(self, pathitems, menu_data, context_name, context_id, perpetual_range_start):
Severity: Minor
Found in resources/lib/services/nfsession/directorybuilder/dir_builder.py - About 35 mins to fix

    Function get_video_list_sorted has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def get_video_list_sorted(self, pathitems, menu_data, sub_genre_id, perpetual_range_start, is_dynamic_id):
    Severity: Minor
    Found in resources/lib/services/nfsession/directorybuilder/dir_builder.py - About 35 mins to fix

      Function get_video_list_search has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def get_video_list_search(self, pathitems, menu_data, search_term, perpetual_range_start, path_params=None):
      Severity: Minor
      Found in resources/lib/services/nfsession/directorybuilder/dir_builder.py - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @measure_exec_time_decorator(is_immediate=True)
    def get_seasons(self, pathitems, tvshowid_dict, perpetual_range_start):
        tvshowid = VideoId.from_dict(tvshowid_dict)
        season_list = self.req_seasons(tvshowid, perpetual_range_start=perpetual_range_start)
        return build_season_listing(season_list, tvshowid, pathitems)
        Severity: Major
        Found in resources/lib/services/nfsession/directorybuilder/dir_builder.py and 1 other location - About 2 hrs to fix
        resources/lib/services/nfsession/directorybuilder/dir_builder.py on lines 71..75

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            @measure_exec_time_decorator(is_immediate=True)
    def get_episodes(self, pathitems, seasonid_dict, perpetual_range_start):
        seasonid = VideoId.from_dict(seasonid_dict)
        episodes_list = self.req_episodes(seasonid, perpetual_range_start=perpetual_range_start)
        return build_episode_listing(episodes_list, seasonid, pathitems)
        Severity: Major
        Found in resources/lib/services/nfsession/directorybuilder/dir_builder.py and 1 other location - About 2 hrs to fix
        resources/lib/services/nfsession/directorybuilder/dir_builder.py on lines 65..69

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status