Sign upLogin

CastagnaIT/plugin.video.netflix

View on GitHub
Star
resources/lib/services/nfsession/directorybuilder/dir_builder_items.py

Summary

Maintainability
B
6 hrs
Test Coverage

Cyclomatic complexity is too high in function _create_profile_item. (12)
Open

def _create_profile_item(profile_guid, is_selected, is_autoselect, is_autoselect_library, detailed_info):
    profile_name = G.LOCAL_DB.get_profile_config('profileName', '???', guid=profile_guid)
    profile_attributes = []
    is_pin_locked = G.LOCAL_DB.get_profile_config('isPinLocked', False, guid=profile_guid)
    if is_pin_locked:
Severity: Minor
Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function _create_video_item. (10)
Open

def _create_video_item(videoid_value, video, video_list, perpetual_range_start, common_data):  # pylint: disable=unused-argument
    if common_data['is_supplemental_type']:
        # 10/10/2022 Broken api? the video trailers are not more identified as supplemental type but as movie type
        # as workaround we check the data type
        videoid = common.VideoId(supplementalid=videoid_value)
Severity: Minor
Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function build_mainmenu_listing. (8)
Open

@measure_exec_time_decorator(is_immediate=True)
def build_mainmenu_listing(loco_list):
    """Builds the main menu listing (my list, continue watching, etc.)"""
    from resources.lib.kodi.context_menu import generate_context_menu_mainmenu
    directory_items = []
Severity: Minor
Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in function build_video_listing. (8)
Open

@measure_exec_time_decorator(is_immediate=True)
def build_video_listing(video_list, menu_data, sub_genre_id=None, pathitems=None, perpetual_range_start=None,
                        mylist_items=None, path_params=None):
    """Build a video listing"""
    trackid = None
Severity: Minor
Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function build_mainmenu_listing has a Cognitive Complexity of 16 (exceeds 10 allowed). Consider refactoring.
Open

def build_mainmenu_listing(loco_list):
    """Builds the main menu listing (my list, continue watching, etc.)"""
    from resources.lib.kodi.context_menu import generate_context_menu_mainmenu
    directory_items = []
    common_data = get_common_data()
Severity: Minor
Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _create_video_item has a Cognitive Complexity of 14 (exceeds 10 allowed). Consider refactoring.
Open

def _create_video_item(videoid_value, video, video_list, perpetual_range_start, common_data):  # pylint: disable=unused-argument
    if common_data['is_supplemental_type']:
        # 10/10/2022 Broken api? the video trailers are not more identified as supplemental type but as movie type
        # as workaround we check the data type
        videoid = common.VideoId(supplementalid=videoid_value)
Severity: Minor
Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_video_listing has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def build_video_listing(video_list, menu_data, sub_genre_id=None, pathitems=None, perpetual_range_start=None,
Severity: Major
Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 50 mins to fix

    Function _create_category_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _create_category_item(list_id, video_list, menu_data, common_data, summary_data):
    Severity: Minor
    Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 35 mins to fix

      Function _create_season_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _create_season_item(tvshowid, seasonid_value, season, season_list, common_data):
      Severity: Minor
      Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 35 mins to fix

        Function _create_profile_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def _create_profile_item(profile_guid, is_selected, is_autoselect, is_autoselect_library, detailed_info):
        Severity: Minor
        Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 35 mins to fix

          Function _create_episode_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def _create_episode_item(seasonid, episodeid_value, episode, episodes_list, common_data):
          Severity: Minor
          Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 35 mins to fix

            Function _create_video_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def _create_video_item(videoid_value, video, video_list, perpetual_range_start, common_data):  # pylint: disable=unused-argument
            Severity: Minor
            Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 35 mins to fix

              Function _create_videolist_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def _create_videolist_item(list_id, video_list, menu_data, common_data, static_lists=False):
              Severity: Minor
              Found in resources/lib/services/nfsession/directorybuilder/dir_builder_items.py - About 35 mins to fix

                There are no issues that match your filters.

                Category
                Status