Sign upLogin

CastagnaIT/plugin.video.netflix

View on GitHub
Star
resources/lib/services/nfsession/msl/events_handler.py

Summary

Maintainability
A
35 mins
Test Coverage

Cyclomatic complexity is too high in method _build_event_params. (6)
Open

    def _build_event_params(self, event_type, event_data, player_state, manifest, loco_data):  # pylint: disable=unused-argument
        """Build data params for an event request"""
        videoid_value = event_data['videoid'].value
        # Get previous elaborated data of the same video id
        # Some tags must remain unchanged between events
Severity: Minor
Found in resources/lib/services/nfsession/msl/events_handler.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function _build_event_params has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _build_event_params(self, event_type, event_data, player_state, manifest, loco_data):  # pylint: disable=unused-argument
Severity: Minor
Found in resources/lib/services/nfsession/msl/events_handler.py - About 35 mins to fix

    At least two spaces before inline comment
    Open

                        'lolomo_id': 'unknown', # loco_data['root_id'],
    Severity: Minor
    Found in resources/lib/services/nfsession/msl/events_handler.py by pep8

    Separate inline comments by at least two spaces.

    An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

    There are no issues that match your filters.

    Category
    Status