Sign upLogin

Cellarise/istanbul-reporter-clover-limits

View on GitHub
Star
lib/clover-limits.js

Summary

Maintainability
F
4 days
Test Coverage

Function addClassStats has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var addClassStats = function addClassStats(node, fileCoverage, writer, jsonResults, limits) {
  var metrics = node.metrics,
    branchByLine = branchCoverageByLine(fileCoverage),
    //funcMap,
    lines,
Severity: Major
Found in lib/clover-limits.js - About 4 hrs to fix

    Function walk has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var walk = function walk(node, collector, writer, level, projectRoot, jsonResults, limits) {
  var metrics,
    slocStats,
    totalFiles = 0,
    totalPackages = 0,
    Severity: Major
    Found in lib/clover-limits.js - About 3 hrs to fix

      File clover-limits.js has 295 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      "use strict";
var path = require("path");
var Report = require("istanbul").Report;
var FileWriter = require("./util/file-writer");
var TreeSummarizer = require("istanbul").TreeSummarizer;
      Severity: Minor
      Found in lib/clover-limits.js - About 3 hrs to fix

        Function addClassStats has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

        var addClassStats = function addClassStats(node, fileCoverage, writer, jsonResults, limits) {
  var metrics = node.metrics,
    branchByLine = branchCoverageByLine(fileCoverage),
    //funcMap,
    lines,
        Severity: Minor
        Found in lib/clover-limits.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function writeReport has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          "writeReport": function writeReport(collector, sync) {
    var summarizer = new TreeSummarizer(),
      outputFile = path.join(this.dir, this.file),
      jsonOutputFile = path.join(this.testDir, this.testFile),
      writer = this.opts.writer || new FileWriter(sync),
        Severity: Minor
        Found in lib/clover-limits.js - About 1 hr to fix

          Function walk has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          var walk = function walk(node, collector, writer, level, projectRoot, jsonResults, limits) {
          Severity: Major
          Found in lib/clover-limits.js - About 50 mins to fix

            Consider simplifying this complex logical expression.
            Open

              if (linePercent < limits.statements ||
    branchesPercent < limits.branches ||
    functionsPercent < limits.functions ||
    lineIgnoredPercent > limits.ignored.statements ||
    branchesIgnoredPercent > limits.ignored.branches ||
            Severity: Major
            Found in lib/clover-limits.js - About 40 mins to fix

              Function addClassStats has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              var addClassStats = function addClassStats(node, fileCoverage, writer, jsonResults, limits) {
              Severity: Minor
              Found in lib/clover-limits.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  writer.println("\t\t\t\t<metrics" +
    attr("statements", metrics.statements.total) +
    attr("coveredstatements", metrics.statements.covered) +
    attr("conditionals", metrics.branches.total) +
    attr("coveredconditionals", metrics.branches.covered) +
                Severity: Major
                Found in lib/clover-limits.js and 1 other location - About 4 hrs to fix
                lib/clover-limits.js on lines 278..285

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 117.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    writer.println("\t\t\t<metrics" +
      attr("statements", metrics.statements.total) +
      attr("coveredstatements", metrics.statements.covered) +
      attr("conditionals", metrics.branches.total) +
      attr("coveredconditionals", metrics.branches.covered) +
                Severity: Major
                Found in lib/clover-limits.js and 1 other location - About 4 hrs to fix
                lib/clover-limits.js on lines 119..126

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 117.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (branchesIgnoredPercent > limits.ignored.branches) {
      result.error = result.error + "Too many branches skipped: actual=" + branchesIgnoredPercent * 100 +
        "% required=" + limits.ignored.branches * 100 +
        "% (branches skipped = " + metrics.branches.skipped +
        " total branches = " + metrics.branches.total + ")" +
                Severity: Major
                Found in lib/clover-limits.js and 1 other location - About 3 hrs to fix
                lib/clover-limits.js on lines 155..161

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (lineIgnoredPercent > limits.ignored.statements) {
      result.error = result.error + "Too many statements skipped: actual=" + lineIgnoredPercent * 100 +
        "% required=" + limits.ignored.statements * 100 +
        "% (statements skipped = " + metrics.statements.skipped +
        " total statements = " + metrics.statements.total + ")" +
                Severity: Major
                Found in lib/clover-limits.js and 1 other location - About 3 hrs to fix
                lib/clover-limits.js on lines 162..168

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (branchesPercent < limits.branches) {
      result.error = result.error + "Insufficient branch coverage: actual=" + branchesPercent * 100 +
        "% required=" + limits.branches * 100 +
        "% (branches covered = " + metrics.branches.covered +
        " total branches = " + metrics.branches.total + ")" +
                Severity: Major
                Found in lib/clover-limits.js and 1 other location - About 3 hrs to fix
                lib/clover-limits.js on lines 135..141

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (linePercent < limits.statements) {
      result.error = result.error + "Insufficient statement coverage: actual=" + linePercent * 100 +
        "% required=" + limits.statements * 100 +
        "% (statements covered = " + metrics.statements.covered +
        " total statements = " + metrics.statements.total + ")" +
                Severity: Major
                Found in lib/clover-limits.js and 1 other location - About 3 hrs to fix
                lib/clover-limits.js on lines 142..148

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status