Cellarise/oauth-rest-atlassian

View on GitHub

Showing 75 of 75 total issues

Function _createSignature has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

exports.OAuth.prototype._createSignature = function (signatureBase, tokenSecret) {
    if (tokenSecret === undefined) {
        tokenSecret = "";
    } else {
        tokenSecret = this._encodeData(tokenSecret);
Severity: Minor
Found in lib/oauth.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _sortRequestParams has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

exports.OAuth.prototype._sortRequestParams = function (argument_pairs) {
    // Sort by name, then value.
    argument_pairs.sort(function (a, b) {
        if (a[0] === b[0]) {
            return a[1] < b[1] ? -1 : 1;
Severity: Minor
Found in lib/oauth.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        coverageStat.lines.pct =
          Math.round(coverageStat.lines.covered / coverageStat.lines.total * 100) || 100;
Severity: Minor
Found in tasks/lib/coverageStats.js and 1 other location - About 55 mins to fix
tasks/lib/coverageStats.js on lines 104..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        coverageStat.lines.pctSkipped =
          Math.round(coverageStat.lines.skipped / coverageStat.lines.total * 100) || 0;
Severity: Minor
Found in tasks/lib/coverageStats.js and 1 other location - About 55 mins to fix
tasks/lib/coverageStats.js on lines 119..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    Object.keys(second.s).forEach(function processkeys(k) {
      ret.s[k] += second.s[k];
    });
Severity: Minor
Found in tasks/test.js and 1 other location - About 55 mins to fix
tasks/test.js on lines 34..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    Object.keys(second.f).forEach(function processkeys(k) {
      ret.f[k] += second.f[k];
    });
Severity: Minor
Found in tasks/test.js and 1 other location - About 55 mins to fix
tasks/test.js on lines 31..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _putOrPost has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

exports.OAuth.prototype._putOrPost = function (method, url, oauth_token, oauth_token_secret, post_body, post_content_type, callback) {
Severity: Major
Found in lib/oauth.js - About 50 mins to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            coverageStat.branches.pctSkipped =
              Math.round(coverageStat.branches.skipped / coverageStat.branches.total * 100) || 0;
    Severity: Major
    Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
    tasks/lib/coverageStats.js on lines 108..109
    tasks/lib/coverageStats.js on lines 110..111
    tasks/lib/coverageStats.js on lines 121..122
    tasks/lib/coverageStats.js on lines 123..124
    tasks/lib/coverageStats.js on lines 125..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            coverageStat.branches.pct =
              Math.round(coverageStat.branches.covered / coverageStat.branches.total * 100) || 100;
    Severity: Major
    Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
    tasks/lib/coverageStats.js on lines 106..107
    tasks/lib/coverageStats.js on lines 108..109
    tasks/lib/coverageStats.js on lines 110..111
    tasks/lib/coverageStats.js on lines 123..124
    tasks/lib/coverageStats.js on lines 125..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            coverageStat.functions.pct =
              Math.round(coverageStat.functions.covered / coverageStat.functions.total * 100) || 100;
    Severity: Major
    Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
    tasks/lib/coverageStats.js on lines 106..107
    tasks/lib/coverageStats.js on lines 108..109
    tasks/lib/coverageStats.js on lines 110..111
    tasks/lib/coverageStats.js on lines 121..122
    tasks/lib/coverageStats.js on lines 123..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            coverageStat.functions.pctSkipped =
              Math.round(coverageStat.functions.skipped / coverageStat.functions.total * 100) || 0;
    Severity: Major
    Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
    tasks/lib/coverageStats.js on lines 106..107
    tasks/lib/coverageStats.js on lines 108..109
    tasks/lib/coverageStats.js on lines 121..122
    tasks/lib/coverageStats.js on lines 123..124
    tasks/lib/coverageStats.js on lines 125..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            coverageStat.statements.pct =
              Math.round(coverageStat.statements.covered / coverageStat.statements.total * 100) || 100;
    Severity: Major
    Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
    tasks/lib/coverageStats.js on lines 106..107
    tasks/lib/coverageStats.js on lines 108..109
    tasks/lib/coverageStats.js on lines 110..111
    tasks/lib/coverageStats.js on lines 121..122
    tasks/lib/coverageStats.js on lines 125..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            coverageStat.statements.pctSkipped =
              Math.round(coverageStat.statements.skipped / coverageStat.statements.total * 100) || 0;
    Severity: Major
    Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
    tasks/lib/coverageStats.js on lines 106..107
    tasks/lib/coverageStats.js on lines 110..111
    tasks/lib/coverageStats.js on lines 121..122
    tasks/lib/coverageStats.js on lines 123..124
    tasks/lib/coverageStats.js on lines 125..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function put has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    exports.OAuth.prototype.put = function (url, oauth_token, oauth_token_secret, post_body, post_content_type, callback) {
    Severity: Minor
    Found in lib/oauth.js - About 45 mins to fix

      Function _normalizeUrl has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.OAuth.prototype._normalizeUrl = function (url) {
          var parsedUrl = URL.parse(url, true);
          var port = "";
          if (parsedUrl.port) {
              if ((parsedUrl.protocol === "http:" && parsedUrl.port !== "80" ) ||
      Severity: Minor
      Found in lib/oauth.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                          if (typeof value === "object") {
                              // TODO: This probably should be recursive
                              for (key2 in value) {
                                  if (value.hasOwnProperty(key2)) {
                                      oauthParameters[key + "[" + key2 + "]"] = value[key2];
      Severity: Major
      Found in lib/oauth.js - About 45 mins to fix

        Function post has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        exports.OAuth.prototype.post = function (url, oauth_token, oauth_token_secret, post_body, post_content_type, callback) {
        Severity: Minor
        Found in lib/oauth.js - About 45 mins to fix

          Function _createClient has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          exports.OAuth.prototype._createClient = function (port, hostname, method, path, headers, sslEnabled) {
          Severity: Minor
          Found in lib/oauth.js - About 45 mins to fix

            Function codeAnalysisTasks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function codeAnalysisTasks(gulp, context) {
              var eslint = require("gulp-eslint");
            
              /**
               * A gulp build task to execute static code analysis on the files at `package.json:directories.lib`.
            Severity: Minor
            Found in tasks/codeAnalysis.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function rest has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function rest(consumer, appConfig, basePath, request, response){
            Severity: Minor
            Found in server.js - About 35 mins to fix
              Severity
              Category
              Status
              Source
              Language