Sign upLogin

CenterForOpenScience/scrapi

View on GitHub
Star
scrapi/base/transformer.py

Summary

Maintainability
A
1 hr
Test Coverage

Function _transform_value has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def _transform_value(self, value, doc, fail=False):
        if isinstance(value, dict):
            return self._transform_dict(value, doc, fail=fail)
        elif isinstance(value, list):
            return self._transform_list(value, doc, fail=fail)
Severity: Minor
Found in scrapi/base/transformer.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return value(doc)
Severity: Major
Found in scrapi/base/transformer.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return self._transform_string(value, doc)
    Severity: Major
    Found in scrapi/base/transformer.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status