Sign upLogin

CenterForOpenScience/waterbutler

View on GitHub
Star
waterbutler/auth/osf/handler.py

Summary

Maintainability
C
7 hrs
Test Coverage

Function _determine_actions has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

    def _determine_actions(self, resource, provider, request, action=None,
                           auth_type=AuthType.SOURCE, path='', version=None):
        """Decide what the user is trying to achieve and what permissions they need to achieve it.
        Returns two values, ``osf_action`` and ``intended_action``.  ``intended_action`` is a tag
        that describes what the user is trying to accomplish.  This tag can have many values,
Severity: Minor
Found in waterbutler/auth/osf/handler.py - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _determine_actions has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def _determine_actions(self, resource, provider, request, action=None,
Severity: Major
Found in waterbutler/auth/osf/handler.py - About 50 mins to fix

    There are no issues that match your filters.

    Category
    Status