Sign upLogin

CenterForOpenScience/waterbutler

View on GitHub
Star
waterbutler/providers/cloudfiles/provider.py

Summary

Maintainability
B
5 hrs
Test Coverage

File provider.py has 325 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os
import hmac
import json
import time
import asyncio
Severity: Minor
Found in waterbutler/providers/cloudfiles/provider.py - About 3 hrs to fix

    Function _extract_endpoints has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def _extract_endpoints(self, data):
        """Pulls both the public and internal cloudfiles urls,
        returned respectively, from the return of tokens
        Very optimized.
        :param dict data: The json response from the token endpoint
    Severity: Minor
    Found in waterbutler/providers/cloudfiles/provider.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if marker['name'] == subdir_path:
                            data.remove(marker)
                            break
    Severity: Major
    Found in waterbutler/providers/cloudfiles/provider.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status