Sign upLogin

CenterForOpenScience/waterbutler

View on GitHub
Star
waterbutler/providers/onedrive/provider.py

Summary

Maintainability
C
1 day
Test Coverage

File provider.py has 650 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import typing
import asyncio
import logging
from http import HTTPStatus
Severity: Major
Found in waterbutler/providers/onedrive/provider.py - About 1 day to fix

    Function _construct_metadata has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def _construct_metadata(self, data: dict, path):
        """Take a file/folder metadata response from OneDrive and a path object representing the
        queried path and return a `OneDriveFileMetadata` object if the repsonse represents a file
        or a list of `OneDriveFileMetadata` and `OneDriveFolderMetadata` objects if the response
        represents a folder. """
    Severity: Minor
    Found in waterbutler/providers/onedrive/provider.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status