Sign upLogin

ChaelCodes/HuntersKeepers

View on GitHub
Star

Showing 57 of 106 total issues

Method has too many lines. [11/10]
Open

  def create
    @move = Move.new(move_params)
    authorize @move
    respond_to do |format|
      if @move.save
Severity: Minor
Found in app/controllers/moves_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def create
    @playbook = Playbook.new(playbook_params)
    authorize @playbook
    respond_to do |format|
      if @playbook.save
Severity: Minor
Found in app/controllers/playbooks_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def create
    @rating = Rating.new(rating_params)
    authorize @rating
    respond_to do |format|
      if @rating.save
Severity: Minor
Found in app/controllers/ratings_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create is too high. [16.16/15]
Open

  def create
    @move = Move.new(move_params)
    authorize @move
    respond_to do |format|
      if @move.save
Severity: Minor
Found in app/controllers/moves_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

Method has too many lines. [11/10]
Open

  def create
    @gear = Gear.new(gear_params)
    authorize @gear
    respond_to do |format|
      if @gear.save
Severity: Minor
Found in app/controllers/gears_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create is too high. [15.17/15]
Open

  def create
    @playbook = Playbook.new(playbook_params)
    authorize @playbook
    respond_to do |format|
      if @playbook.save
Severity: Minor
Found in app/controllers/playbooks_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

Assignment Branch Condition size for create is too high. [15.17/15]
Open

  def create
    @improvement = Improvement.new(improvement_params)
    authorize @improvement
    respond_to do |format|
      if @improvement.save
Severity: Minor
Found in app/controllers/improvements_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def create
    @rating = Rating.new(rating_params)
    authorize @rating
    respond_to do |format|
      if @rating.save
Severity: Major
Found in app/controllers/ratings_controller.rb and 1 other location - About 1 hr to fix
app/controllers/gears_controller.rb on lines 29..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def create
    @gear = Gear.new(gear_params)
    authorize @gear
    respond_to do |format|
      if @gear.save
Severity: Major
Found in app/controllers/gears_controller.rb and 1 other location - About 1 hr to fix
app/controllers/ratings_controller.rb on lines 30..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is too long. [87/80]
Open

        format.html { redirect_to @rating, notice: 'Rating was successfully created.' }
Severity: Minor
Found in app/controllers/ratings_controller.rb by rubocop

Line is too long. [82/80]
Open

        format.json { render json: @rating.errors, status: :unprocessable_entity }
Severity: Minor
Found in app/controllers/ratings_controller.rb by rubocop

Line is too long. [82/80]
Open

        format.json { render json: @hunter.errors, status: :unprocessable_entity }
Severity: Minor
Found in app/controllers/hunters_controller.rb by rubocop

Line is too long. [93/80]
Open

    params.require(:gear).permit(:name, :description, :harm, :armor, :playbook_id, :tag_list)
Severity: Minor
Found in app/controllers/gears_controller.rb by rubocop

Line is too long. [110/80]
Open

        redirect_to hunter_hunters_improvements_url, notice: 'Hunters improvement was successfully destroyed.'
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Line is too long. [114/80]
Open

  json.available_improvements hunter.available_improvements, partial: 'improvements/improvement', as: :improvement
Severity: Minor
Found in app/views/hunters/_hunter.json.jbuilder by rubocop

Line is too long. [99/80]
Open

json.partial! 'hunters_improvements/hunters_improvement', hunters_improvement: @hunters_improvement
Severity: Minor
Found in app/views/hunters_improvements/show.json.jbuilder by rubocop

Line is too long. [82/80]
Open

  # @param experience [Integer] The amount of experience the hunter has not spent.
Severity: Minor
Found in app/controllers/hunters_controller.rb by rubocop

Line is too long. [97/80]
Open

  validates :luck, numericality: { less_than_or_equal_to: MAX_LUCK, greater_than_or_equal_to: 0 }
Severity: Minor
Found in app/models/hunter.rb by rubocop

Line is too long. [107/80]
Open

    @hunters_improvement.improvement = Improvement.find(params[:improvement_id]) if params[:improvement_id]
Severity: Minor
Found in app/controllers/hunters_improvements_controller.rb by rubocop

Line is too long. [82/80]
Open

  # @see HuntersController#hunter_params See hunter_params for accepted parameters
Severity: Minor
Found in app/controllers/hunters_controller.rb by rubocop
Severity
Category
Status
Source
Language