Sign upLogin

CharafeddineMechalikh/PureEdgeSim

View on GitHub
Star
PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java

Summary

Maintainability
C
1 day
Test Coverage

Method createComputingNode has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected ComputingNode createComputingNode(Element datacenterElement, SimulationParameters.TYPES type)
            throws NoSuchAlgorithmException, NoSuchMethodException, SecurityException, InstantiationException,
            IllegalAccessException, IllegalArgumentException, InvocationTargetException {
        // SecureRandom is preferred to generate random values.
        Random random = SecureRandom.getInstanceStrong();
Severity: Major
Found in PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java - About 3 hrs to fix

    Method generateDataCenters has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        protected void generateDataCenters(String file, TYPES type) {
        // Fill list with edge data centers
        try (InputStream serversFile = new FileInputStream(file)) {
            DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
    Severity: Minor
    Found in PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method generateDataCenters has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected void generateDataCenters(String file, TYPES type) {
        // Fill list with edge data centers
        try (InputStream serversFile = new FileInputStream(file)) {
            DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
    Severity: Minor
    Found in PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java - About 1 hr to fix

      Method createComputingNode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected ComputingNode createComputingNode(Element datacenterElement, SimulationParameters.TYPES type)
            throws NoSuchAlgorithmException, NoSuchMethodException, SecurityException, InstantiationException,
            IllegalAccessException, IllegalArgumentException, InvocationTargetException {
        // SecureRandom is preferred to generate random values.
        Random random = SecureRandom.getInstanceStrong();
      Severity: Minor
      Found in PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method generateEdgeDevices has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public void generateEdgeDevices() {
        // Generate edge devices instances from edge devices types in xml file.
        try (InputStream devicesFile = new FileInputStream(SimulationParameters.edgeDevicesFile)) {

            DocumentBuilderFactory dbFactory = DocumentBuilderFactory.newInstance();
      Severity: Minor
      Found in PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      } else {
                    edgeOnlyList.add(computingNode);
                    mistAndEdgeListSensorsExcluded.add(computingNode);
                    if (SimulationParameters.enableOrchestrators
                            && "EDGE".equals(SimulationParameters.deployOrchestrators)) {
      Severity: Minor
      Found in PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java and 1 other location - About 35 mins to fix
      PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java on lines 172..179

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      if (computingNode.getType() == TYPES.CLOUD) {
                    cloudOnlyList.add(computingNode);
                    mistAndCloudListSensorsExcluded.add(computingNode);
                    if (SimulationParameters.enableOrchestrators
                            && "CLOUD".equals(SimulationParameters.deployOrchestrators)) {
      Severity: Minor
      Found in PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java and 1 other location - About 35 mins to fix
      PureEdgeSim/com/mechalikh/pureedgesim/datacentersmanager/DefaultComputingNodesGenerator.java on lines 179..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 44.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status