Sign upLogin

CharafeddineMechalikh/PureEdgeSim

View on GitHub
Star
PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java

Summary

Maintainability
C
1 day
Test Coverage

Method send has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public void send(ComputingNode from, ComputingNode to, Task task, double fileSize, TransferProgress.Type type) {
        List<ComputingNode> vertexList = new ArrayList<>(5);
        List<NetworkLink> edgeList = new ArrayList<>(5);

        // If both are edge devices (one hop far from each other), send directly.
Severity: Minor
Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java - About 1 hr to fix

    Method transferFinished has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected void transferFinished(TransferProgress transfer) {

        // If it is an offloading request that is sent to the orchestrator
        if (transfer.getTransferType() == TransferProgress.Type.REQUEST) {
            // in case this node is the orchestrator
    Severity: Minor
    Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java - About 1 hr to fix

      Method send has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public void send(ComputingNode from, ComputingNode to, Task task, double fileSize, TransferProgress.Type type) {
        List<ComputingNode> vertexList = new ArrayList<>(5);
        List<NetworkLink> edgeList = new ArrayList<>(5);

        // If both are edge devices (one hop far from each other), send directly.
      Severity: Minor
      Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method transferFinished has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected void transferFinished(TransferProgress transfer) {

        // If it is an offloading request that is sent to the orchestrator
        if (transfer.getTransferType() == TransferProgress.Type.REQUEST) {
            // in case this node is the orchestrator
      Severity: Minor
      Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method send has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public void send(ComputingNode from, ComputingNode to, Task task, double fileSize, TransferProgress.Type type) {
      Severity: Minor
      Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public void addContainer(Task task) {
        if (task.getRegistry() != task.getOffloadingDestination())
            send(task.getRegistry(), task.getOffloadingDestination(), task, task.getContainerSizeInBits(),
                    TransferProgress.Type.CONTAINER);
        else
        Severity: Minor
        Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java and 1 other location - About 40 mins to fix
        PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java on lines 139..146

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public void sendResultFromOrchToDev(Task task) {
        if (task.getOrchestrator() != task.getEdgeDevice())
            send(task.getOrchestrator(), task.getEdgeDevice(), task, task.getOutputSizeInBits(),
                    TransferProgress.Type.RESULTS_TO_DEV);
        else
        Severity: Minor
        Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java and 1 other location - About 40 mins to fix
        PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java on lines 157..163

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 52.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                else if (transfer.getTransferType() == TransferProgress.Type.TASK) {
            // in case this node is the destination
            if (transfer.getVertexList().get(0) == transfer.getTask().getOffloadingDestination()) {
                updateEdgeDevicesRemainingEnergy(transfer, transfer.getTask().getEdgeDevice(),
                        transfer.getTask().getOffloadingDestination());
        Severity: Minor
        Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java and 1 other location - About 35 mins to fix
        PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java on lines 180..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (transfer.getTransferType() == TransferProgress.Type.REQUEST) {
            // in case this node is the orchestrator

            if (transfer.getVertexList().get(0) == transfer.getTask().getOrchestrator()) {
                updateEdgeDevicesRemainingEnergy(transfer, transfer.getTask().getEdgeDevice(),
        Severity: Minor
        Found in PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java and 1 other location - About 35 mins to fix
        PureEdgeSim/com/mechalikh/pureedgesim/network/DefaultNetworkModel.java on lines 190..198

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status