Sign upLogin

ChattyCrow/chattycrow_ruby

View on GitHub
Star
lib/chatty_crow/request/mail.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method add_file has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

      def add_file(options = {})
        # Get file
        file = options.delete(:file)

        # Raise argument error when argument file missing!
Severity: Minor
Found in lib/chatty_crow/request/mail.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_data_from_am has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def set_data_from_am
        # Contacts
        @contacts  = ChattyCrow.wrap(@am_mail.to)

        # Channel?
Severity: Minor
Found in lib/chatty_crow/request/mail.rb - About 1 hr to fix

    Method set_data_from_am has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def set_data_from_am
        # Contacts
        @contacts  = ChattyCrow.wrap(@am_mail.to)

        # Channel?
    Severity: Minor
    Found in lib/chatty_crow/request/mail.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method file_base64 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def file_base64
        f = @file

        # ActionDispatch::Http::UploadedFile (get tempfile)
        if defined?(::ActionDispatch) && f.instance_of?(::ActionDispatch::Http::UploadedFile)
    Severity: Minor
    Found in lib/chatty_crow/request/mail.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status