Sign upLogin

ChiefOfGxBxL/WC3MapTranslator

View on GitHub
Star
src/translators/RegionsTranslator.ts

Summary

Maintainability
A
3 hrs
Test Coverage

Function warToJson has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static warToJson(buffer: Buffer): JsonResult<Region[]> {
        const result = [];
        const outBufferToJSON = new W3Buffer(buffer);

        const fileVersion = outBufferToJSON.readInt(), // File version
Severity: Minor
Found in src/translators/RegionsTranslator.ts - About 1 hr to fix

    Function jsonToWar has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static jsonToWar(regionsJson: Region[]): WarResult {
        const outBufferToWar = new HexBuffer();

        /*
         * Header
    Severity: Minor
    Found in src/translators/RegionsTranslator.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (region.weatherEffect) {
                outBufferToWar.addChars(region.weatherEffect); // Weather effect is optional - defaults to 0000 for "none"
            } else {
                // We can't put a string "0000", because ASCII 0's differ from 0x0 bytes
                outBufferToWar.addByte(0);
      Severity: Minor
      Found in src/translators/RegionsTranslator.ts and 1 other location - About 45 mins to fix
      src/translators/ObjectsTranslator.ts on lines 144..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status