Sign upLogin

ChiefOfGxBxL/WC3MapTranslator

View on GitHub
Star
src/translators/TerrainTranslator.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function warToJson has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static warToJson(buffer: Buffer): JsonResult<Terrain> {
        // create buffer
        const result: Terrain = {
            tileset: '',
            customTileset: false,
Severity: Major
Found in src/translators/TerrainTranslator.ts - About 4 hrs to fix

    Function jsonToWar has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static jsonToWar(terrainJson: Terrain): WarResult {
        const outBufferToWar = new HexBuffer();

        /*
         * Header
    Severity: Major
    Found in src/translators/TerrainTranslator.ts - About 2 hrs to fix

      Function jsonToWar has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static jsonToWar(terrainJson: Terrain): WarResult {
        const outBufferToWar = new HexBuffer();

        /*
         * Header
      Severity: Minor
      Found in src/translators/TerrainTranslator.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status