Chiliec/yii2-vote

View on GitHub

Showing 16 of 16 total issues

Function run has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function run()
    {
        if (Yii::$app->request->getIsAjax()) {
            Yii::$app->response->format = Response::FORMAT_JSON;
            if (null === $modelId = (int)Yii::$app->request->post('modelId')) {
Severity: Minor
Found in actions/VoteAction.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        if (Yii::$app->request->getIsAjax()) {
            Yii::$app->response->format = Response::FORMAT_JSON;
            if (null === $modelId = (int)Yii::$app->request->post('modelId')) {
Severity: Major
Found in actions/VoteAction.php - About 2 hrs to fix

    Method init has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function init()
        {
            parent::init();
            if (!isset($this->model)) {
                throw new InvalidParamException(Yii::t('vote', 'Model not configurated'));
    Severity: Minor
    Found in widgets/Vote.php - About 1 hr to fix

      Function getModelIdByName has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getModelIdByName($modelName)
          {
              if (null !== $models = Yii::$app->getModule('vote')->models) {
                  $modelId = array_search($modelName, $models);
                  if (is_int($modelId)) {
      Severity: Minor
      Found in models/Rating.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function up has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public function up()
          {
              if ($this->db->driverName !== 'sqlite') {
                  if ($this->db->driverName === 'pgsql') {
                      $this->execute('ALTER TABLE ' . $this->tableName . ' ALTER COLUMN "date" DROP DEFAULT');
      Severity: Minor
      Found in migrations/m150127_165542_update_rating_table.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
      return [
          'The user is not recognized' => 'Der Benutzer wurde nicht erkannt',
          'Guests are not allowed to vote' => 'Gästen ist es nicht erlaubt abzustimmen',
          'The model is not registered' => 'Das Model ist nicht registriert',
      Severity: Minor
      Found in messages/de/vote.php and 1 other location - About 45 mins to fix
      messages/ru/vote.php on lines 1..24

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      <?php
      /**
       * @link https://github.com/Chiliec/yii2-vote
       * @author Vladimir Babin <vovababin@gmail.com>
       * @license http://opensource.org/licenses/BSD-3-Clause
      Severity: Minor
      Found in messages/ru/vote.php and 1 other location - About 45 mins to fix
      messages/de/vote.php on lines 1..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 80.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function getModelNameById has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function getModelNameById($modelId)
          {
              if (null !== $models = Yii::$app->getModule('vote')->models) {
                  if (isset($models[$modelId])) {
                      if (is_array($models[$modelId])) {
      Severity: Minor
      Found in models/Rating.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return ['content' => Yii::t('vote', 'The user is not recognized')];
      Severity: Major
      Found in actions/VoteAction.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return ['content' => Yii::t('vote', 'Thanks for your opinion'), 'success' => true];
        Severity: Major
        Found in actions/VoteAction.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                                  return ['content' => Yii::t('vote', 'Your vote has been changed. Thanks!'), 'success' => true, 'changed' => true];
          Severity: Major
          Found in actions/VoteAction.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return ['content' => Yii::t('vote', 'You have already voted!')];
            Severity: Major
            Found in actions/VoteAction.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                      return ['content' => Yii::t('vote', 'Your vote is accepted. Thanks!'), 'success' => true];
              Severity: Major
              Found in actions/VoteAction.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                        return ['content' => Yii::t('vote', 'Validation error')];
                Severity: Major
                Found in actions/VoteAction.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return ['content' => Yii::t('vote', 'The model is not registered')];
                  Severity: Major
                  Found in actions/VoteAction.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return ['content' => Yii::t('vote', 'Validation error')];
                    Severity: Major
                    Found in actions/VoteAction.php - About 30 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language