Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
client/src/assets/player/shared/player-options-builder/hls-options-builder.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function getPluginOptions has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async getPluginOptions () {
    const segmentsSha256Url = this.options.hls.segmentsSha256Url

    if (!segmentsSha256Url) {
      logger.info('No segmentsSha256Url found. Disabling P2P & redundancy.')
Severity: Minor
Found in client/src/assets/player/shared/player-options-builder/hls-options-builder.ts - About 1 hr to fix

    Function getP2PMediaLoaderOptions has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private getP2PMediaLoaderOptions (options: {
    redundancyUrlManager: RedundancyUrlManager | null
    segmentValidator: SegmentValidator | null
  }): HlsJsEngineSettings {
    const { redundancyUrlManager, segmentValidator } = options
    Severity: Minor
    Found in client/src/assets/player/shared/player-options-builder/hls-options-builder.ts - About 1 hr to fix

      Function getP2PMediaLoaderOptions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        private getP2PMediaLoaderOptions (options: {
    redundancyUrlManager: RedundancyUrlManager | null
    segmentValidator: SegmentValidator | null
  }): HlsJsEngineSettings {
    const { redundancyUrlManager, segmentValidator } = options
      Severity: Minor
      Found in client/src/assets/player/shared/player-options-builder/hls-options-builder.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPluginOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        async getPluginOptions () {
    const segmentsSha256Url = this.options.hls.segmentsSha256Url

    if (!segmentsSha256Url) {
      logger.info('No segmentsSha256Url found. Disabling P2P & redundancy.')
      Severity: Minor
      Found in client/src/assets/player/shared/player-options-builder/hls-options-builder.ts - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status