Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star

Showing 3,313 of 3,313 total issues

Function doRefresh has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

async function doRefresh <T extends MActorFull | MActorAccountChannelId> (options: RefreshOptions<T>): RefreshResult <MActorFull> {
  const { actor: actorArg, fetchedType } = options

  // We need more attributes
  const actor = fetchedType === 'all'
Severity: Minor
Found in server/core/lib/activitypub/actors/refresh.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildFileFormatFlags has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function buildFileFormatFlags (fileUrl: ActivityVideoUrlObject, isStreamingPlaylist: boolean) {
  const attachment = fileUrl.attachment || []

  const formatHints = attachment.filter(a => a.type === 'PropertyValue' && a.name === 'peertube_format_flag')
  if (formatHints.length === 0) {
Severity: Minor
Found in server/core/lib/activitypub/videos/shared/object-to-model-attributes.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildCommonVideosParams has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  buildCommonVideosParams (options: CommonVideoParams & { params: HttpParams }) {
    const {
      params,
      videoPagination,
      sort,
Severity: Minor
Found in client/src/app/shared/shared-main/video/video.service.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildTasks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  private buildTasks () {
    const tasks: VideoStudioTask[] = []
    const value = this.form.value

    const cut = value['cut']
Severity: Minor
Found in client/src/app/+video-studio/edit/video-studio-edit.component.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ngOnChanges has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  ngOnChanges (changes: SimpleChanges) {
    if (changes['displayOptions'] || !this.displayOptions) {
      this.displayOptions = {
        ...this.defaultDisplayOptions,
        avatar: this.serverService.getHTMLConfig().client.videos.miniature.displayAuthorAvatar,
Severity: Minor
Found in client/src/app/shared/shared-video-miniature/videos-list.component.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function checkEndMessage has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function checkEndMessage (options: {
  message: string
  requiresEmailVerification: boolean
  requiresApproval: boolean
  afterEmailVerification: boolean
Severity: Minor
Found in client/e2e/src/suites-local/signup.e2e-spec.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function injectThemes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  private injectThemes (themes: ServerConfigTheme[], fromLocalStorage = false) {
    this.themes = themes

    logger.info(`Injecting ${this.themes.length} themes.`)
Severity: Minor
Found in client/src/app/core/theme/theme.service.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildClasses has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  private buildClasses () {
    let avatarSize = '100%'
    let initialFontSize = '22px'

    this.classes = [ 'avatar' ]
Severity: Minor
Found in client/src/app/shared/shared-actor-image/actor-avatar.component.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildForm has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  buildForm (obj: BuildFormArgument, defaultValues: BuildFormDefaultValues = {}) {
    const formErrors: FormReactiveErrors = {}
    const validationMessages: FormReactiveValidationMessages = {}
    const group: { [key: string]: any } = {}
Severity: Minor
Found in client/src/app/shared/shared-forms/form-validator.service.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function waitUntilSegmentGeneration has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  async waitUntilSegmentGeneration (options: OverrideCommandOptions & {
    server: PeerTubeServer
    videoUUID: string
    playlistNumber: number
    segment: number
Severity: Minor
Found in packages/server-commands/src/videos/live-command.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildRequest has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

function buildRequest (req: request.Test, options: CommonRequestParams) {
  if (options.contentType) req.set('Accept', options.contentType)
  if (options.responseType) req.responseType(options.responseType)
  if (options.token) req.set('Authorization', 'Bearer ' + options.token)
  if (options.range) req.set('Range', options.range)
Severity: Minor
Found in packages/server-commands/src/requests/requests.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processStudioTranscoding has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export async function processStudioTranscoding (options: ProcessOptions<RunnerJobStudioTranscodingPayload>) {
  const { server, job, runnerToken } = options
  const payload = job.payload

  let videoInputPath: string
Severity: Minor
Found in apps/peertube-runner/src/server/process/shared/process-studio.ts - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    {
      const t = this.templates.find(t => t.name === 'preHtml')
      if (t) this.preHtmlTemplate = t.template
    }
Severity: Major
Found in client/src/app/shared/shared-main/buttons/help.component.ts and 7 other locations - About 55 mins to fix
client/src/app/shared/shared-forms/peertube-checkbox.component.ts on lines 38..41
client/src/app/shared/shared-forms/peertube-checkbox.component.ts on lines 43..46
client/src/app/shared/shared-forms/select/select-options.component.ts on lines 61..64
client/src/app/shared/shared-main/buttons/help.component.ts on lines 43..46
client/src/app/shared/shared-main/buttons/help.component.ts on lines 48..51
client/src/app/shared/shared-video-miniature/videos-selection.component.ts on lines 82..85
client/src/app/shared/shared-video-miniature/videos-selection.component.ts on lines 87..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

  constructor (
    private authHttp: HttpClient,
    private restExtractor: RestExtractor,
    private restService: RestService,
    private videoService: VideoService,
Severity: Major
Found in client/src/app/shared/shared-search/search.service.ts and 14 other locations - About 55 mins to fix
client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 65..71
client/src/app/+my-account/my-account-applications/my-account-applications.component.ts on lines 22..28
client/src/app/+my-account/my-account-import-export/my-account-import.component.ts on lines 38..44
client/src/app/+my-account/my-account-settings/my-account-danger-zone/my-account-danger-zone.component.ts on lines 12..18
client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.ts on lines 39..46
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 63..69
client/src/app/+signup/+register/register.component.ts on lines 82..88
client/src/app/+signup/+verify-account/verify-account-email/verify-account-email.component.ts on lines 28..35
client/src/app/+videos/video-list/video-user-subscriptions.component.ts on lines 38..46
client/src/app/core/theme/theme.service.ts on lines 24..30
client/src/app/menu/notification-dropdown.component.ts on lines 43..50
client/src/app/shared/shared-main/users/user-notification.service.ts on lines 16..22
client/src/app/shared/shared-user-subscription/subscribe-button.component.ts on lines 48..54
client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 52..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    {
      const t = this.templates.find(t => t.name === 'item')
      if (t) this.customItemTemplate = t.template
    }
Severity: Major
Found in client/src/app/shared/shared-forms/select/select-options.component.ts and 7 other locations - About 55 mins to fix
client/src/app/shared/shared-forms/peertube-checkbox.component.ts on lines 38..41
client/src/app/shared/shared-forms/peertube-checkbox.component.ts on lines 43..46
client/src/app/shared/shared-main/buttons/help.component.ts on lines 38..41
client/src/app/shared/shared-main/buttons/help.component.ts on lines 43..46
client/src/app/shared/shared-main/buttons/help.component.ts on lines 48..51
client/src/app/shared/shared-video-miniature/videos-selection.component.ts on lines 82..85
client/src/app/shared/shared-video-miniature/videos-selection.component.ts on lines 87..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    {
      const t = this.templates.find(t => t.name === 'label')
      if (t) this.labelTemplate = t.template
    }
Severity: Major
Found in client/src/app/shared/shared-forms/peertube-checkbox.component.ts and 7 other locations - About 55 mins to fix
client/src/app/shared/shared-forms/peertube-checkbox.component.ts on lines 43..46
client/src/app/shared/shared-forms/select/select-options.component.ts on lines 61..64
client/src/app/shared/shared-main/buttons/help.component.ts on lines 38..41
client/src/app/shared/shared-main/buttons/help.component.ts on lines 43..46
client/src/app/shared/shared-main/buttons/help.component.ts on lines 48..51
client/src/app/shared/shared-video-miniature/videos-selection.component.ts on lines 82..85
client/src/app/shared/shared-video-miniature/videos-selection.component.ts on lines 87..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

  constructor (
    private signupService: SignupService,
    private server: ServerService,
    private authService: AuthService,
    private notifier: Notifier,
Severity: Major
Found in client/src/app/+signup/+verify-account/verify-account-email/verify-account-email.component.ts and 14 other locations - About 55 mins to fix
client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 65..71
client/src/app/+my-account/my-account-applications/my-account-applications.component.ts on lines 22..28
client/src/app/+my-account/my-account-import-export/my-account-import.component.ts on lines 38..44
client/src/app/+my-account/my-account-settings/my-account-danger-zone/my-account-danger-zone.component.ts on lines 12..18
client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.ts on lines 39..46
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 63..69
client/src/app/+signup/+register/register.component.ts on lines 82..88
client/src/app/+videos/video-list/video-user-subscriptions.component.ts on lines 38..46
client/src/app/core/theme/theme.service.ts on lines 24..30
client/src/app/menu/notification-dropdown.component.ts on lines 43..50
client/src/app/shared/shared-main/users/user-notification.service.ts on lines 16..22
client/src/app/shared/shared-search/search.service.ts on lines 25..31
client/src/app/shared/shared-user-subscription/subscribe-button.component.ts on lines 48..54
client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 52..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

  constructor (
    private authService: AuthService,
    private server: ServerService,
    private userImportExportService: UserImportExportService,
    private resumableUploadService: UploadxService,
Severity: Major
Found in client/src/app/+my-account/my-account-import-export/my-account-import.component.ts and 14 other locations - About 55 mins to fix
client/src/app/+accounts/account-video-channels/account-video-channels.component.ts on lines 65..71
client/src/app/+my-account/my-account-applications/my-account-applications.component.ts on lines 22..28
client/src/app/+my-account/my-account-settings/my-account-danger-zone/my-account-danger-zone.component.ts on lines 12..18
client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.ts on lines 39..46
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 63..69
client/src/app/+signup/+register/register.component.ts on lines 82..88
client/src/app/+signup/+verify-account/verify-account-email/verify-account-email.component.ts on lines 28..35
client/src/app/+videos/video-list/video-user-subscriptions.component.ts on lines 38..46
client/src/app/core/theme/theme.service.ts on lines 24..30
client/src/app/menu/notification-dropdown.component.ts on lines 43..50
client/src/app/shared/shared-main/users/user-notification.service.ts on lines 16..22
client/src/app/shared/shared-search/search.service.ts on lines 25..31
client/src/app/shared/shared-user-subscription/subscribe-button.component.ts on lines 48..54
client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 52..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    {
      const t = this.templates.find(t => t.name === 'customHtml')
      if (t) this.customHtmlTemplate = t.template
    }
Severity: Major
Found in client/src/app/shared/shared-main/buttons/help.component.ts and 7 other locations - About 55 mins to fix
client/src/app/shared/shared-forms/peertube-checkbox.component.ts on lines 38..41
client/src/app/shared/shared-forms/peertube-checkbox.component.ts on lines 43..46
client/src/app/shared/shared-forms/select/select-options.component.ts on lines 61..64
client/src/app/shared/shared-main/buttons/help.component.ts on lines 38..41
client/src/app/shared/shared-main/buttons/help.component.ts on lines 48..51
client/src/app/shared/shared-video-miniature/videos-selection.component.ts on lines 82..85
client/src/app/shared/shared-video-miniature/videos-selection.component.ts on lines 87..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

  constructor (
    private accountService: AccountService,
    private videoChannelService: VideoChannelService,
    private videoService: VideoService,
    private markdown: MarkdownService,
Severity: Major
Found in client/src/app/+accounts/account-video-channels/account-video-channels.component.ts and 14 other locations - About 55 mins to fix
client/src/app/+my-account/my-account-applications/my-account-applications.component.ts on lines 22..28
client/src/app/+my-account/my-account-import-export/my-account-import.component.ts on lines 38..44
client/src/app/+my-account/my-account-settings/my-account-danger-zone/my-account-danger-zone.component.ts on lines 12..18
client/src/app/+my-account/my-account-settings/my-account-two-factor/my-account-two-factor.component.ts on lines 39..46
client/src/app/+my-library/+my-video-channels/my-video-channels.component.ts on lines 63..69
client/src/app/+signup/+register/register.component.ts on lines 82..88
client/src/app/+signup/+verify-account/verify-account-email/verify-account-email.component.ts on lines 28..35
client/src/app/+videos/video-list/video-user-subscriptions.component.ts on lines 38..46
client/src/app/core/theme/theme.service.ts on lines 24..30
client/src/app/menu/notification-dropdown.component.ts on lines 43..50
client/src/app/shared/shared-main/users/user-notification.service.ts on lines 16..22
client/src/app/shared/shared-search/search.service.ts on lines 25..31
client/src/app/shared/shared-user-subscription/subscribe-button.component.ts on lines 48..54
client/src/app/shared/shared-video-miniature/download/video-download.component.ts on lines 52..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language