Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star

Showing 3,313 of 3,313 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export interface VideoPlaylistCreate {
  displayName: string
  privacy: VideoPlaylistPrivacyType

  description?: string
Severity: Minor
Found in packages/models/src/videos/playlist/video-playlist-create.model.ts and 1 other location - About 35 mins to fix
packages/models/src/videos/playlist/video-playlist-update.model.ts on lines 3..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return this.postBodyRequest({
      ...options,

      path: apiPath,
      fields: { npmName, path, pluginVersion },
Severity: Minor
Found in packages/server-commands/src/server/plugins-command.ts and 1 other location - About 35 mins to fix
packages/server-commands/src/videos/video-passwords-command.ts on lines 15..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  logger.info(`Replacing live ${liveVideo.uuid} by replay ${replayDirectory}.`, { replayInAnotherDirectory, ...lTags(liveVideo.uuid) })
Severity: Minor
Found in server/core/lib/job-queue/handlers/video-live-ending.ts and 1 other location - About 35 mins to fix
server/core/lib/video-captions.ts on lines 110..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

    if (modelName === 'CommentAutomaticTags') return 'CommentAutomaticTagModel'
Severity: Major
Found in server/core/models/shared/model-builder.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        if (video.isBlacklisted() || video.isBlocked()) return VideoPlaylistElementType.UNAVAILABLE
    Severity: Major
    Found in server/core/models/video/video-playlist-element.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        return 'mp4a.40.2' // Fallback
      Severity: Major
      Found in server/core/helpers/ffmpeg/codecs.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return !!redundancy
        Severity: Major
        Found in server/scripts/prune-storage.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                if (!file) return false
          Severity: Major
          Found in server/scripts/prune-storage.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              if (audioCodecName === 'mp3') return 'mp4a.40.34'
            Severity: Major
            Found in server/core/helpers/ffmpeg/codecs.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return parseInt(match[1], 10) * 1024 * 1024 * 1024 * 1024 +
      parseInt(match[2], 10) * 1024 * 1024
              Severity: Major
              Found in server/core/helpers/core-utils.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return VideoPlaylistElementType.REGULAR
                Severity: Major
                Found in server/core/models/video/video-playlist-element.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return modelName + 'Model'
                  Severity: Major
                  Found in server/core/models/shared/model-builder.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                      return `${videoCodec}.${baseProfile}${level}`
                    Severity: Major
                    Found in server/core/helpers/ffmpeg/codecs.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return parseInt(match[1], 10) * 1024 * 1024 * 1024 +
      parseInt(match[2], 10) * 1024 * 1024
                      Severity: Major
                      Found in server/core/helpers/core-utils.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                          return imageBytes <= 15 * kB
                        Severity: Major
                        Found in server/core/helpers/image-utils.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                            return checkMimetypeRegex(file.mimetype, mimeTypeRegex)
                          Severity: Major
                          Found in server/core/helpers/custom-validators/misc.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                              if (!setValidStoryboard(video)) return fail('preview (storyboard)')
                            Severity: Major
                            Found in server/core/helpers/custom-validators/activitypub/videos.ts - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                if (!isActivityPubVideoDurationValid(video.duration)) return fail('duration format')
                              Severity: Major
                              Found in server/core/helpers/custom-validators/activitypub/videos.ts - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                  if (!isUUIDValid(video.uuid)) return fail('uuid')
                                Severity: Major
                                Found in server/core/helpers/custom-validators/activitypub/videos.ts - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                      return next()
                                  Severity: Major
                                  Found in server/core/middlewares/validators/redundancy.ts - About 30 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language