Chocobozzz/PeerTube

View on GitHub

Showing 3,313 of 3,313 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  {
    await utils.queryInterface.addColumn('videoComment', 'heldForReview', {
      type: Sequelize.BOOLEAN,
      defaultValue: false,
      allowNull: false
Severity: Major
Found in server/core/initializers/migrations/0845-auto-tags.ts and 1 other location - About 3 hrs to fix
server/core/initializers/migrations/0860-caption-generated.ts on lines 10..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    return this.authHttp
               .get<ResultList<Video>>(VideoChannelService.BASE_VIDEO_CHANNEL_URL + videoChannel.nameWithHost + '/videos', { params })
               .pipe(
                 switchMap(res => this.extractVideos(res)),
                 catchError(err => this.restExtractor.handleError(err))
Severity: Major
Found in client/src/app/shared/shared-main/video/video.service.ts and 1 other location - About 3 hrs to fix
client/src/app/shared/shared-main/video/video.service.ts on lines 190..195

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  getAccount (id: number | string): Observable<Account> {
    return this.authHttp.get<ServerAccount>(AccountService.BASE_ACCOUNT_URL + id)
               .pipe(
                 map(accountHash => new Account(accountHash)),
                 tap(account => this.accountLoaded.next(account)),
Severity: Major
Found in client/src/app/shared/shared-main/account/account.service.ts and 1 other location - About 3 hrs to fix
client/src/app/shared/shared-main/channel/video-channel.service.ts on lines 42..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const ABUSE_REASON_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [ Validators.required, Validators.minLength(2), Validators.maxLength(3000) ],
  MESSAGES: {
    required: $localize`Report reason is required.`,
    minlength: $localize`Report reason must be at least 2 characters long.`,
Severity: Major
Found in client/src/app/shared/form-validators/abuse-validators.ts and 10 other locations - About 2 hrs to fix
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const VIDEO_CHANNEL_DISPLAY_NAME_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [
    Validators.required,
    Validators.minLength(1),
    Validators.maxLength(50)
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const ABUSE_MESSAGE_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [ Validators.required, Validators.minLength(2), Validators.maxLength(3000) ],
  MESSAGES: {
    required: $localize`Abuse message is required.`,
    minlength: $localize`Abuse message must be at least 2 characters long.`,
Severity: Major
Found in client/src/app/shared/form-validators/abuse-validators.ts and 10 other locations - About 2 hrs to fix
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const REGISTRATION_MODERATION_RESPONSE_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [ Validators.required, Validators.minLength(2), Validators.maxLength(3000) ],
  MESSAGES: {
    required: $localize`Moderation response is required.`,
    minlength: $localize`Moderation response must be at least 2 characters long.`,
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const SUBJECT_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [
    Validators.required,
    Validators.minLength(1),
    Validators.maxLength(120)
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const REGISTER_REASON_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [ Validators.required, Validators.minLength(2), Validators.maxLength(3000) ],
  MESSAGES: {
    required: $localize`Registration reason is required.`,
    minlength: $localize`Registration reason must be at least 2 characters long.`,
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const FROM_NAME_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [
    Validators.required,
    Validators.minLength(1),
    Validators.maxLength(120)
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const VIDEO_COMMENT_TEXT_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [ Validators.required, Validators.minLength(1), Validators.maxLength(3000) ],
  MESSAGES: {
    required: $localize`Comment is required.`,
    minlength: $localize`Comment must be at least 2 characters long.`,
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const ABUSE_MODERATION_COMMENT_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [ Validators.required, Validators.minLength(2), Validators.maxLength(3000) ],
  MESSAGES: {
    required: $localize`Moderation comment is required.`,
    minlength: $localize`Moderation comment must be at least 2 characters long.`,
Severity: Major
Found in client/src/app/shared/form-validators/abuse-validators.ts and 10 other locations - About 2 hrs to fix
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const VIDEO_PLAYLIST_DISPLAY_NAME_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [
    Validators.required,
    Validators.minLength(1),
    Validators.maxLength(120)
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/instance-validators.ts on lines 38..49
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  ngAfterViewChecked () {
    if (window.location.hash && window.location.hash !== this.lastScrollHash) {
      this.viewportScroller.scrollToAnchor(window.location.hash.replace('#', ''))

      this.lastScrollHash = window.location.hash
client/src/app/+about/about-peertube/about-peertube.component.ts on lines 18..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 11 locations. Consider refactoring.
Open

export const BODY_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [
    Validators.required,
    Validators.minLength(3),
    Validators.maxLength(5000)
client/src/app/+admin/moderation/registration-list/process-registration-validators.ts on lines 4..11
client/src/app/+signup/+register/shared/register-validators.ts on lines 11..18
client/src/app/shared/form-validators/abuse-validators.ts on lines 4..11
client/src/app/shared/form-validators/abuse-validators.ts on lines 13..20
client/src/app/shared/form-validators/abuse-validators.ts on lines 22..29
client/src/app/shared/form-validators/instance-validators.ts on lines 12..23
client/src/app/shared/form-validators/instance-validators.ts on lines 25..36
client/src/app/shared/form-validators/video-channel-validators.ts on lines 17..28
client/src/app/shared/form-validators/video-comment-validators.ts on lines 4..11
client/src/app/shared/form-validators/video-playlist-validators.ts on lines 5..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  ngAfterViewChecked () {
    if (window.location.hash && window.location.hash !== this.lastScrollHash) {
      this.viewportScroller.scrollToAnchor(window.location.hash.replace('#', ''))

      this.lastScrollHash = window.location.hash
client/src/app/+my-account/my-account-settings/my-account-settings.component.ts on lines 61..67

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  createNotification (user: MUserWithNotificationSetting) {
    const notification = UserNotificationModel.build<UserNotificationModelForApi>({
      type: UserNotificationType.NEW_PEERTUBE_VERSION,
      userId: user.id,
      applicationId: this.payload.application.id
server/core/lib/notifier/shared/abuse/new-abuse-for-moderators.ts on lines 31..40
server/core/lib/notifier/shared/instance/direct-registration-for-moderators.ts on lines 28..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  createNotification (user: MUserWithNotificationSetting) {
    const notification = UserNotificationModel.build<UserNotificationModelForApi>({
      type: UserNotificationType.NEW_ABUSE_FOR_MODERATORS,
      userId: user.id,
      abuseId: this.payload.abuseInstance.id
server/core/lib/notifier/shared/instance/direct-registration-for-moderators.ts on lines 28..37
server/core/lib/notifier/shared/instance/new-peertube-version-for-admins.ts on lines 33..42

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export const CACHE_SIZE_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [ Validators.required, Validators.min(1), Validators.pattern('[0-9]+') ],
  MESSAGES: {
    required: $localize`Cache size is required.`,
    min: $localize`Cache size must be greater than 1.`,
client/src/app/shared/form-validators/custom-config-validators.ts on lines 43..50
client/src/app/shared/form-validators/custom-config-validators.ts on lines 100..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

export const SIGNUP_MINIMUM_AGE_VALIDATOR: BuildFormValidator = {
  VALIDATORS: [ Validators.required, Validators.min(1), Validators.pattern('[0-9]+') ],
  MESSAGES: {
    required: $localize`Signup minimum age is required.`,
    min: $localize`Signup minimum age must be greater than 1.`,
client/src/app/shared/form-validators/custom-config-validators.ts on lines 25..32
client/src/app/shared/form-validators/custom-config-validators.ts on lines 100..107

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language