Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/controllers/feeds/video-podcast-feeds.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function generatePodcastItem has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function generatePodcastItem (options: {
  video: VideoModel
  liveItem: boolean
  media: PodcastMedia[]
}) {
Severity: Minor
Found in server/core/controllers/feeds/video-podcast-feeds.ts - About 1 hr to fix

    Function generateVideoPodcastFeed has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function generateVideoPodcastFeed (req: express.Request, res: express.Response) {
  const videoChannel = res.locals.videoChannel

  const { name, userName, description, imageUrl, accountImageUrl, email, link, accountLink } = await buildFeedMetadata({ videoChannel })
    Severity: Minor
    Found in server/core/controllers/feeds/video-podcast-feeds.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        if (account.Actor.hasImage(ActorImageType.AVATAR)) {
    const avatar = maxBy(account.Actor.Avatars, 'width')
    personImage = WEBSERVER.URL + avatar.getStaticPath()
  }
      Severity: Major
      Found in server/core/controllers/feeds/video-podcast-feeds.ts and 1 other location - About 1 hr to fix
      server/core/controllers/feeds/shared/common-feed-utils.ts on lines 106..109

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        InternalEventEmitter.Instance.on(event, ({ video }) => {
    if (video.remote) return

    podcastApiCache.clearGroupSafe(buildPodcastGroupsCache({ channelId: video.channelId }))
  })
      Severity: Minor
      Found in server/core/controllers/feeds/video-podcast-feeds.ts and 1 other location - About 35 mins to fix
      server/core/controllers/activitypub/client.ts on lines 180..184

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status