Sign upLogin

Chocobozzz/PeerTube

View on GitHub
Star
server/core/lib/activitypub/process/process-dislike.ts

Summary

Maintainability
A
2 hrs
Test Coverage

Function processDislike has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function processDislike (activity: ActivityDislike, byActor: MActorSignature) {
  const videoUrl = activity.object
  const byAccount = byActor.Account

  if (!byAccount) throw new Error('Cannot create dislike with the non account actor ' + byActor.url)
Severity: Minor
Found in server/core/lib/activitypub/process/process-dislike.ts - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    async function processDislikeActivity (options: APProcessorOptions<ActivityDislike>) {
  const { activity, byActor } = options
  return retryTransactionWrapper(processDislike, activity, byActor)
}
    Severity: Major
    Found in server/core/lib/activitypub/process/process-dislike.ts and 2 other locations - About 45 mins to fix
    server/core/lib/activitypub/process/process-flag.ts on lines 14..18
    server/core/lib/activitypub/process/process-like.ts on lines 12..16

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        if (existingRate && existingRate.type === 'like') {
      await video.decrement('likes', { transaction: t })
      video.likes--
    }
    Severity: Minor
    Found in server/core/lib/activitypub/process/process-dislike.ts and 1 other location - About 40 mins to fix
    server/core/lib/activitypub/process/process-like.ts on lines 46..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status