Chocobozzz/PeerTube

View on GitHub
server/scripts/prune-storage.ts

Summary

Maintainability
C
1 day
Test Coverage

Function prune has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async prune () {
    const dirs = Object.values(CONFIG.STORAGE)

    if (uniqify(dirs).length !== dirs.length) {
      console.error('Cannot prune storage because you put multiple storage keys in the same directory.')
Severity: Minor
Found in server/scripts/prune-storage.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

          if (!file) return false
    Severity: Major
    Found in server/scripts/prune-storage.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return !!redundancy
      Severity: Major
      Found in server/scripts/prune-storage.ts - About 30 mins to fix

        Identical blocks of code found in 14 locations. Consider refactoring.
        Open

        run()
          .then(() => process.exit(0))
          .catch(err => {
            console.error(err)
            process.exit(-1)
        Severity: Major
        Found in server/scripts/prune-storage.ts and 13 other locations - About 1 hr to fix
        scripts/generate-code-contributors.ts on lines 3..8
        server/scripts/create-generate-storyboard-job.ts on lines 22..27
        server/scripts/create-import-video-file-job.ts on lines 21..26
        server/scripts/create-move-video-storage-job.ts on lines 36..41
        server/scripts/house-keeping.ts on lines 20..25
        server/scripts/migrations/peertube-4.0.ts on lines 17..23
        server/scripts/migrations/peertube-4.2.ts on lines 17..22
        server/scripts/migrations/peertube-5.0.ts on lines 11..16
        server/scripts/plugin/install.ts on lines 24..29
        server/scripts/plugin/uninstall.ts on lines 16..21
        server/scripts/update-host.ts on lines 25..30
        server/scripts/update-object-storage-url.ts on lines 17..22
        packages/types-generator/generate-package.ts on lines 16..21

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 63.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private doesWebVideoFileExistFactory () {
            return (filePath: string) => {
              // Don't delete private directory
              if (filePath === DIRECTORIES.WEB_VIDEOS.PRIVATE) return true
        
        
        Severity: Major
        Found in server/scripts/prune-storage.ts and 1 other location - About 1 hr to fix
        server/scripts/prune-storage.ts on lines 230..237

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          private doesHLSPlaylistExistFactory () {
            return (hlsPath: string) => {
              // Don't delete private directory
              if (hlsPath === DIRECTORIES.HLS_STREAMING_PLAYLIST.PRIVATE) return true
        
        
        Severity: Major
        Found in server/scripts/prune-storage.ts and 1 other location - About 1 hr to fix
        server/scripts/prune-storage.ts on lines 221..228

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private doesOriginalFileExistFactory () {
            return (key: string) => {
              const filename = this.sanitizeKey(key, CONFIG.OBJECT_STORAGE.ORIGINAL_VIDEO_FILES)
        
              return VideoSourceModel.doesOwnedFileExist(filename, FileStorage.OBJECT_STORAGE)
        Severity: Major
        Found in server/scripts/prune-storage.ts and 2 other locations - About 1 hr to fix
        server/scripts/prune-storage.ts on lines 104..110
        server/scripts/prune-storage.ts on lines 128..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private doesWebVideoFileExistFactory () {
            return (key: string) => {
              const filename = this.sanitizeKey(key, CONFIG.OBJECT_STORAGE.WEB_VIDEOS)
        
              return VideoFileModel.doesOwnedFileExist(filename, FileStorage.OBJECT_STORAGE)
        Severity: Major
        Found in server/scripts/prune-storage.ts and 2 other locations - About 1 hr to fix
        server/scripts/prune-storage.ts on lines 120..126
        server/scripts/prune-storage.ts on lines 128..134

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private doesUserExportFileExistFactory () {
            return (key: string) => {
              const filename = this.sanitizeKey(key, CONFIG.OBJECT_STORAGE.USER_EXPORTS)
        
              return UserExportModel.doesOwnedFileExist(filename, FileStorage.OBJECT_STORAGE)
        Severity: Major
        Found in server/scripts/prune-storage.ts and 2 other locations - About 1 hr to fix
        server/scripts/prune-storage.ts on lines 104..110
        server/scripts/prune-storage.ts on lines 120..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private doesActorImageExistFactory () {
            return async (filePath: string) => {
              const image = await ActorImageModel.loadByFilename(basename(filePath))
        
              return !!image
        Severity: Major
        Found in server/scripts/prune-storage.ts and 2 other locations - About 40 mins to fix
        server/scripts/prune-storage.ts on lines 271..277
        server/scripts/prune-storage.ts on lines 279..285

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private doesCaptionExistFactory () {
            return async (filePath: string) => {
              const caption = await VideoCaptionModel.loadWithVideoByFilename(basename(filePath))
        
              return !!caption
        Severity: Major
        Found in server/scripts/prune-storage.ts and 2 other locations - About 40 mins to fix
        server/scripts/prune-storage.ts on lines 263..269
        server/scripts/prune-storage.ts on lines 271..277

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          private doesStoryboardExistFactory () {
            return async (filePath: string) => {
              const storyboard = await StoryboardModel.loadByFilename(basename(filePath))
        
              return !!storyboard
        Severity: Major
        Found in server/scripts/prune-storage.ts and 2 other locations - About 40 mins to fix
        server/scripts/prune-storage.ts on lines 263..269
        server/scripts/prune-storage.ts on lines 279..285

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status