ChrisMacNaughton/BtSync

View on GitHub

Showing 4 of 4 total issues

Class Directory has 32 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Directory
    include HTTParty
    include BtCommunicator
    default_params output: 'json'
    attr_reader :secret, :name, :errors
Severity: Minor
Found in lib/btsync/directory.rb - About 4 hrs to fix

    Class BtSync has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class BtSync
      include BtCommunicator
      include HTTParty
      default_params output: 'json'
      def initialize(options = {})
    Severity: Minor
    Found in lib/btsync.rb - About 3 hrs to fix

      Method build_repo has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def build_repo(uri, distribution, components, arch, add_deb_src)
      Severity: Minor
      Found in cookbooks/apt/providers/repository.rb - About 35 mins to fix

        Method remove_host_by_ip has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def remove_host_by_ip(ip, port = nil)
              known_hosts.each do |id, host|
                host = host.split(':')
                if ip == host[0]
                  next if port != host[1] unless port.nil?
        Severity: Minor
        Found in lib/btsync/directory.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language