Sign upLogin

CiscoUcs/imcsdk

View on GitHub
Star
imcsdk/apis/admin/certificate.py

Summary

Maintainability
F
1 wk
Test Coverage

File certificate.py has 366 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright 2016 Cisco Systems, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
Severity: Minor
Found in imcsdk/apis/admin/certificate.py - About 4 hrs to fix

    Function certificate_signing_request_generate has 14 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def certificate_signing_request_generate(handle, name, org, locality, state,
    Severity: Major
    Found in imcsdk/apis/admin/certificate.py - About 1 hr to fix

      Function certificate_upload has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def certificate_upload(handle, username, password, server, file_name, protocol):
      Severity: Minor
      Found in imcsdk/apis/admin/certificate.py - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        Severity: Major
        Found in imcsdk/apis/admin/certificate.py and 1 other location - About 1 wk to fix
        imcsdk/apis/v2/admin/certificate.py on lines 0..432

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 818.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status